add check of preconditions in `run` step.

add check of preconditions in `run` step.

BUG=
R=ahe@google.com

Committed: https://github.com/dart-lang/sdk/commit/e551bef8ba9c9e6b255e256047440e72fcf13454

[Siggi Cherem (dart-lang), 2017-05-31 21:15:42]

sigmund@google.com changed reviewers:
+ ahe@google.com

[Siggi Cherem (dart-lang), 2017-05-31 21:15:43]

https://codereview.chromium.org/2914773003/diff/1/pkg/front_end/test/fasta/te...
File pkg/front_end/test/fasta/testing/suite.dart (right):

https://codereview.chromium.org/2914773003/diff/1/pkg/front_end/test/fasta/te...
pkg/front_end/test/fasta/testing/suite.dart:181: 1, "Executed `Run` step before
initializing the context.");
not sure if you prefer to indicate these checks as failures or simply assert or
throw and let the testing report it as a crash.

Happy to change it however you like.

[ahe, 2017-06-01 10:45:43]

lgtm

https://codereview.chromium.org/2914773003/diff/1/pkg/front_end/test/fasta/te...
File pkg/front_end/test/fasta/testing/suite.dart (right):

https://codereview.chromium.org/2914773003/diff/1/pkg/front_end/test/fasta/te...
pkg/front_end/test/fasta/testing/suite.dart:181: 1, "Executed `Run` step before
initializing the context.");
On 2017/05/31 21:15:43, Siggi Cherem (dart-lang) wrote:
> not sure if you prefer to indicate these checks as failures or simply assert
or
> throw and let the testing report it as a crash.
> 
> Happy to change it however you like.

Sounds like a crash to me.

[Siggi Cherem (dart-lang), 2017-06-07 22:46:01]

Description was changed from

==========
add check of preconditions in `run` step.

BUG=
==========

to

==========
add check of preconditions in `run` step.

BUG=
R=ahe@google.com

Committed:
https://github.com/dart-lang/sdk/commit/e551bef8ba9c9e6b255e256047440e72fcf13454
==========

[Siggi Cherem (dart-lang), 2017-06-07 22:46:02]

Committed patchset #2 (id:20001) manually as
e551bef8ba9c9e6b255e256047440e72fcf13454 (presubmit successful).