Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Issue 2953673002: Send microsecond resolution timestamps to Java history page so they can be sent back. (Closed)

Created:
3 years, 6 months ago by skym
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

Send microsecond resolution timestamps to Java history page so they can be sent back. When an entry on the history page is deleted, we create history deletion directives that are sent through sync. These are required to support offline history deletions, and make sure these are properly propagated. However, these deletion directives rely on exact matches in timestamps, which are in microseconds since the epoch. The History page on Android converted microsecond timestamps to millisecond timestamps for Java compatibility, but when these timestamps were handed to the logic that created history deletion directives, they were now slightly off. This change simply plumbs through microsecond timestamps through the java code and back. BUG=729020 Review-Url: https://codereview.chromium.org/2935783002 Cr-Original-Commit-Position: refs/heads/master@{#478756} Review-Url: https://codereview.chromium.org/2953673002 . Cr-Commit-Position: refs/branch-heads/3112@{#429} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/ec2a6b24c7b356aa35cbe950a49bf4cd7f1909bb

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
skym
3 years, 6 months ago (2017-06-21 22:23:44 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ec2a6b24c7b356aa35cbe950a49bf4cd7f1909bb.

Powered by Google App Engine
This is Rietveld 408576698