[DevTools] Migrate inspector-protocol/{timeline,worker} tests to new harness

[DevTools] Migrate inspector-protocol/{timeline,worker} tests to new harness

BUG=734762
Review-Url: https://codereview.chromium.org/2953663003
Cr-Commit-Position: refs/heads/master@{#481726}
Committed: https://chromium.googlesource.com/chromium/src/+/65423b1d5cae8e20dd8155231c3d43e8319011aa

[dgozman, 2017-06-22 00:03:42]

dgozman@chromium.org changed reviewers:
+ caseq@chromium.org

[dgozman, 2017-06-22 00:03:42]

Take a look please.

[caseq, 2017-06-22 19:32:42]

lgtm

https://codereview.chromium.org/2953663003/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/inspector-protocol/resources/tracing-test.js
(right):

https://codereview.chromium.org/2953663003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/resources/tracing-test.js:8:
startTracing(callback) {
nit: if you're rewriting this beyond any recognition, it would be nice to have
promises instead of callbacks ;)

https://codereview.chromium.org/2953663003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/resources/tracing-test.js:79:
// Assure multiple in-lfight reads are fine (also, save on latencies).
mind fixing my typo while you're here? ;-)

https://codereview.chromium.org/2953663003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector-protocol/timeline/fetch-as-stream.js
(right):

https://codereview.chromium.org/2953663003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/timeline/fetch-as-stream.js:22:
var element = document.getElementById('test');
Style (indent + opening '{')

https://codereview.chromium.org/2953663003/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/inspector-protocol/timeline/page-frames.js
(right):

https://codereview.chromium.org/2953663003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/timeline/page-frames.js:21:
tracingHelper.invokeAsyncWithTracing('performActions', finish);
nit: I'd put those as await new Promise(fulfill =>
tracingHelper.invokeAsyncWithTracing('performActions', fulfill))

https://codereview.chromium.org/2953663003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/timeline/page-frames.js:27:
dumpFrame(frame);
indent (or forEach)

https://codereview.chromium.org/2953663003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/timeline/page-frames.js:32:
dumpFrame(event.args['data']);
ditto.

https://codereview.chromium.org/2953663003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector-protocol/timeline/timeline-layout.js
(right):

https://codereview.chromium.org/2953663003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/timeline/timeline-layout.js:20:
await session.evaluate(performActions.toString());
note that most of the time waiting for evaluate(performActions) is redundant.

https://codereview.chromium.org/2953663003/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/inspector-protocol/timeline/timeline-raf.js
(right):

https://codereview.chromium.org/2953663003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/timeline/timeline-raf.js:6: 
nuke 1 empty line here.

https://codereview.chromium.org/2953663003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector-protocol/timeline/timeline-timer.js
(right):

https://codereview.chromium.org/2953663003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/timeline/timeline-timer.js:25:
testRunner.log('SUCCESS: testFunctionTimerFired');
Let's nuke it altogether, it doesn't have much sense in its present form.

[dgozman, 2017-06-22 21:49:00]

https://codereview.chromium.org/2953663003/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/inspector-protocol/resources/tracing-test.js
(right):

https://codereview.chromium.org/2953663003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/resources/tracing-test.js:8:
startTracing(callback) {
On 2017/06/22 19:32:41, caseq wrote:
> nit: if you're rewriting this beyond any recognition, it would be nice to have
> promises instead of callbacks ;)

Done.

https://codereview.chromium.org/2953663003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/resources/tracing-test.js:79:
// Assure multiple in-lfight reads are fine (also, save on latencies).
On 2017/06/22 19:32:41, caseq wrote:
> mind fixing my typo while you're here? ;-)

Done.

https://codereview.chromium.org/2953663003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector-protocol/timeline/fetch-as-stream.js
(right):

https://codereview.chromium.org/2953663003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/timeline/fetch-as-stream.js:22:
var element = document.getElementById('test');
On 2017/06/22 19:32:41, caseq wrote:
> Style (indent + opening '{')

Done.

https://codereview.chromium.org/2953663003/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/inspector-protocol/timeline/page-frames.js
(right):

https://codereview.chromium.org/2953663003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/timeline/page-frames.js:21:
tracingHelper.invokeAsyncWithTracing('performActions', finish);
On 2017/06/22 19:32:41, caseq wrote:
> nit: I'd put those as await new Promise(fulfill =>
> tracingHelper.invokeAsyncWithTracing('performActions', fulfill))

Done.

https://codereview.chromium.org/2953663003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/timeline/page-frames.js:27:
dumpFrame(frame);
On 2017/06/22 19:32:41, caseq wrote:
> indent (or forEach)

Done.

https://codereview.chromium.org/2953663003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector-protocol/timeline/timeline-layout.js
(right):

https://codereview.chromium.org/2953663003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/timeline/timeline-layout.js:20:
await session.evaluate(performActions.toString());
On 2017/06/22 19:32:41, caseq wrote:
> note that most of the time waiting for evaluate(performActions) is redundant.

Correct!

https://codereview.chromium.org/2953663003/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/inspector-protocol/timeline/timeline-raf.js
(right):

https://codereview.chromium.org/2953663003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/timeline/timeline-raf.js:6: 
On 2017/06/22 19:32:41, caseq wrote:
> nuke 1 empty line here.

Done.

https://codereview.chromium.org/2953663003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector-protocol/timeline/timeline-timer.js
(right):

https://codereview.chromium.org/2953663003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/timeline/timeline-timer.js:25:
testRunner.log('SUCCESS: testFunctionTimerFired');
On 2017/06/22 19:32:42, caseq wrote:
> Let's nuke it altogether, it doesn't have much sense in its present form.

Done.

[dgozman, 2017-06-22 21:49:14]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2017-06-22 21:49:14]

The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org
Link to the patchset: https://codereview.chromium.org/2953663003/#ps20001
(title: "addressed comments")

[commit-bot: I haz the power, 2017-06-22 21:49:38]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-22 23:52:42]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498168154364330,
"parent_rev": "5f2725f68003a78440a8c381b258bc338e910232", "commit_rev":
"65423b1d5cae8e20dd8155231c3d43e8319011aa"}

[commit-bot: I haz the power, 2017-06-22 23:52:56]

Description was changed from

==========
[DevTools] Migrate inspector-protocol/{timeline,worker} tests to new harness

BUG=734762
==========

to

==========
[DevTools] Migrate inspector-protocol/{timeline,worker} tests to new harness

BUG=734762

Review-Url: https://codereview.chromium.org/2953663003
Cr-Commit-Position: refs/heads/master@{#481726}
Committed:
https://chromium.googlesource.com/chromium/src/+/65423b1d5cae8e20dd8155231c3d...
==========

[commit-bot: I haz the power, 2017-06-22 23:52:58]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/65423b1d5cae8e20dd8155231c3d...