Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 2953643004: Roll buildtools 7f2cacbbe2..38477c2e10 (Closed)

Created:
3 years, 6 months ago by Dirk Pranke
Modified:
3 years, 6 months ago
Reviewers:
brettw
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll buildtools 7f2cacbbe2..38477c2e10 In order to roll GN 7c9bd5f020..bedb4b202b (r465654:r481731) and pick up the following changes: a104997ecbfd Allow overriding script executable in .gn file 18697c83b41f Move if, else, true, false into a keyword category d4a5e98235da [tracing] Switch to new heap dump format. 8480d86659b8 tools/gn: Implement Windows SDK version command line switch 3e0d5228e24d Use ContainsValue() instead of std::find() in tools/ e4a28698a612 Fix GN bootstrap 118577369265 [spelling] existance to existence 21886543a0cb Fix a bug in `gn analyze` for host-only file mods. f8bf5083fb27 Fix gn get_label_info comment 05f56d412142 allocator: remove ENABLE_MEMORY_TASK_PROFILER and use only USE_ALLOCATOR_SHIM e329e9ec19db Fix GN bootstrap 2928b5dc30a1 Add information on the requirements for a new Chromium port. 73228cd43d2e allocator: rename use_experimental_allocator_shim to use_allocator_shim 797723cd4453 Fix GN bootstrap 84fa8b0864ae Replace sanitizers:deps with exe_and_shlib_deps (Chromium repo only) d77555bcaf03 GN: Fix single-file compilations in VS2017 projects cbbd560a5c57 gn: get rid of GetRealPath() function cf2a4bf9cb35 gn: convert WrapUnique calls to MakeUnique where possible dfb837a97c2e gn: fix bootstrap on windows 777e1cd5ec01 Fix gn bootstrap after https://codereview.chromium.org/2872503003 25e109413ae5 gn: Document gen's --check flag. 145252018a78 Add a GUID to base::SharedMemoryHandle. b154afcbc07f memory-infra: Move dump level check to observer and rename session state 9b718c790912 Fix GN bootstrap 643d6bc90fea gn: fix bootstrap.py after https://codereview.chromium.org/2846893003 dd1ae15f741a gn docs: Add a missing closing paren. 0088ee5017f4 GN: aix port along with linux_s390x, linux_ppc64 and linux_ppc64le support. 4a4589fc42e3 memory-infra: Start disentangling tracing from memory-infra 7fd3f6718896 Add curly brackets to list of characters that gn needs to escape ca2ec763405c Improvements to uses of base::SmallMap ddb3babce43a Use $root:default as a "default" rule TBR=brettw@chromium.org Review-Url: https://codereview.chromium.org/2953643004 Cr-Commit-Position: refs/heads/master@{#481774} Committed: https://chromium.googlesource.com/chromium/src/+/3391d2ce4059ebe801dd8310d13d8dc59293600e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Dirk Pranke
3 years, 6 months ago (2017-06-23 00:26:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2953643004/1
3 years, 6 months ago (2017-06-23 00:26:32 UTC) #3
brettw
lgtm
3 years, 6 months ago (2017-06-23 01:25:00 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/3391d2ce4059ebe801dd8310d13d8dc59293600e
3 years, 6 months ago (2017-06-23 01:52:59 UTC) #7
tandrii(chromium)
3 years, 6 months ago (2017-06-23 09:46:41 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2956623002/ by tandrii@chromium.org.

The reason for reverting is: Probably broke incremental builds on trybots.

BUG=736215.

Powered by Google App Engine
This is Rietveld 408576698