Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2953643002:
Replaced synthetic MouseEvent in CustomButton::AcceleratorPressed() with just an Event. (Closed)
DescriptionReplaced synthetic MouseEvent in CustomButton::AcceleratorPressed() with just an Event.
BUG=NONE
Review-Url: https://codereview.chromium.org/2953643002
Cr-Commit-Position: refs/heads/master@{#486095}
Committed: https://chromium.googlesource.com/chromium/src/+/5de7b2c8d25ea655809484f5dc37a4253cb84213
Patch Set 1 #
Total comments: 3
Patch Set 2 : Changed ui::Event to ui::KeyEvent. #
Total comments: 4
Patch Set 3 : Removed unnecessary local variables. #
Messages
Total messages: 24 (15 generated)
The CQ bit was checked by bruthig@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
bruthig@chromium.org changed reviewers: + sky@chromium.org
sky@, can you take a look? https://codereview.chromium.org/2953643002/diff/1/ui/events/event.h File ui/events/event.h (right): https://codereview.chromium.org/2953643002/diff/1/ui/events/event.h#newcode299 ui/events/event.h:299: Event(EventType type, base::TimeTicks time_stamp, int flags); Move this to line 55.
https://codereview.chromium.org/2953643002/diff/1/ui/views/controls/button/cu... File ui/views/controls/button/custom_button.cc (right): https://codereview.chromium.org/2953643002/diff/1/ui/views/controls/button/cu... ui/views/controls/button/custom_button.cc:321: ui::Event synthetic_event(ui::ET_UNKNOWN, ui::EventTimeForNow(), Given we create an accelerator from a KeyEvent, wouldn't it make more sense to convert the accelerator to a KeyEvent here?
The CQ bit was checked by bruthig@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
sky@, can you take another quick look? https://codereview.chromium.org/2953643002/diff/1/ui/views/controls/button/cu... File ui/views/controls/button/custom_button.cc (right): https://codereview.chromium.org/2953643002/diff/1/ui/views/controls/button/cu... ui/views/controls/button/custom_button.cc:321: ui::Event synthetic_event(ui::ET_UNKNOWN, ui::EventTimeForNow(), On 2017/06/22 00:55:48, sky OOO wrote: > Given we create an accelerator from a KeyEvent, wouldn't it make more sense to > convert the accelerator to a KeyEvent here? Done.
LGTM https://codereview.chromium.org/2953643002/diff/20001/ui/base/accelerators/ac... File ui/base/accelerators/accelerator.cc (right): https://codereview.chromium.org/2953643002/diff/20001/ui/base/accelerators/ac... ui/base/accelerators/accelerator.cc:71: KeyEvent key_event(key_state() == Accelerator::KeyState::PRESSED Remove the local and do a return directly. https://codereview.chromium.org/2953643002/diff/20001/ui/views/controls/butto... File ui/views/controls/button/custom_button.cc (right): https://codereview.chromium.org/2953643002/diff/20001/ui/views/controls/butto... ui/views/controls/button/custom_button.cc:321: ui::KeyEvent synthetic_event = accelerator.ToKeyEvent(); No need for the local here either.
No need to review. https://codereview.chromium.org/2953643002/diff/20001/ui/base/accelerators/ac... File ui/base/accelerators/accelerator.cc (right): https://codereview.chromium.org/2953643002/diff/20001/ui/base/accelerators/ac... ui/base/accelerators/accelerator.cc:71: KeyEvent key_event(key_state() == Accelerator::KeyState::PRESSED On 2017/07/11 17:19:43, sky wrote: > Remove the local and do a return directly. Done. https://codereview.chromium.org/2953643002/diff/20001/ui/views/controls/butto... File ui/views/controls/button/custom_button.cc (right): https://codereview.chromium.org/2953643002/diff/20001/ui/views/controls/butto... ui/views/controls/button/custom_button.cc:321: ui::KeyEvent synthetic_event = accelerator.ToKeyEvent(); On 2017/07/11 17:19:43, sky wrote: > No need for the local here either. Done.
The CQ bit was checked by bruthig@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org Link to the patchset: https://codereview.chromium.org/2953643002/#ps40001 (title: "Removed unnecessary local variables.")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by bruthig@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1499885076238040,
"parent_rev": "226ca87e080ea1eedeb4b35342a4fad4ffb05d92", "commit_rev":
"5de7b2c8d25ea655809484f5dc37a4253cb84213"}
Message was sent while issue was closed.
Description was changed from ========== Replaced synthetic MouseEvent in CustomButton::AcceleratorPressed() with just an Event. BUG=NONE ========== to ========== Replaced synthetic MouseEvent in CustomButton::AcceleratorPressed() with just an Event. BUG=NONE Review-Url: https://codereview.chromium.org/2953643002 Cr-Commit-Position: refs/heads/master@{#486095} Committed: https://chromium.googlesource.com/chromium/src/+/5de7b2c8d25ea655809484f5dc37... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/5de7b2c8d25ea655809484f5dc37... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
