PlzNavigate: fix empty FirstPartyForCookies in tests.

PlzNavigate: fix empty FirstPartyForCookies in tests.

This CL swaps the order of execution of WebFrameTestClient::WillSendRequest and
the part where FirstPartyForCookies and RequestorOrigin are set.

FirstPartyForCookies is used in WebFrameTestClient::WillSendRequest.
Using the wrong order caused the following test to fail:
TEST=
 * external/wpt/url/failure.html
 * fast/loader/main-document-url-for-non-http-loads.html
 * http/tests/cache/iframe-304-crash.html
 * http/tests/history/post-replace-state-reload.html
 * http/tests/inspector/network/network-datareceived.html
 * http/tests/inspector/resource-parameters-ipv6.html
 * http/tests/loading/307-after-303-after-post.html
 * http/tests/loading/redirect-methods.html
 * http/tests/misc/window-dot-stop.html
 * http/tests/navigation/location-reload-after-post.php

BUG=735424
Review-Url: https://codereview.chromium.org/2953583002
Cr-Commit-Position: refs/heads/master@{#482621}
Committed: https://chromium.googlesource.com/chromium/src/+/f06bfc089846a2175801cf7d249f292cfb337940

[arthursonzogni, 2017-06-21 15:49:11]

The CQ bit was checked by arthursonzogni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-21 15:49:23]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-21 15:59:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-21 15:59:57]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[arthursonzogni, 2017-06-22 08:47:19]

The CQ bit was checked by arthursonzogni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-22 08:47:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-22 10:21:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-22 10:21:11]

Dry run: This issue passed the CQ dry run.

[arthursonzogni, 2017-06-22 13:49:17]

arthursonzogni@chromium.org changed reviewers:
+ clamy@chromium.org

[arthursonzogni, 2017-06-22 13:49:18]

Hi Camille,

Could you please review this?

[arthursonzogni, 2017-06-27 09:37:18]

Gentle ping. ;-)

[clamy, 2017-06-27 13:05:38]

Thanks! Lgtm.

[arthursonzogni, 2017-06-27 13:06:35]

On 2017/06/27 13:05:38, clamy wrote:
> Thanks! Lgtm.

Thanks!

[arthursonzogni, 2017-06-27 13:06:42]

The CQ bit was checked by arthursonzogni@chromium.org

[commit-bot: I haz the power, 2017-06-27 13:06:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-27 14:34:05]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498568802600550,
"parent_rev": "466810f5ace297383edfec38cee478cace8d79ce", "commit_rev":
"f06bfc089846a2175801cf7d249f292cfb337940"}

[commit-bot: I haz the power, 2017-06-27 14:34:16]

Description was changed from

==========
PlzNavigate: fix empty FirstPartyForCookies in tests.

This CL swaps the order of execution of WebFrameTestClient::WillSendRequest and
the part where FirstPartyForCookies and RequestorOrigin are set.

FirstPartyForCookies is used in WebFrameTestClient::WillSendRequest.
Using the wrong order caused the following test to fail:
TEST=
 * external/wpt/url/failure.html
 * fast/loader/main-document-url-for-non-http-loads.html
 * http/tests/cache/iframe-304-crash.html
 * http/tests/history/post-replace-state-reload.html
 * http/tests/inspector/network/network-datareceived.html
 * http/tests/inspector/resource-parameters-ipv6.html
 * http/tests/loading/307-after-303-after-post.html
 * http/tests/loading/redirect-methods.html
 * http/tests/misc/window-dot-stop.html
 * http/tests/navigation/location-reload-after-post.php

BUG=735424
==========

to

==========
PlzNavigate: fix empty FirstPartyForCookies in tests.

This CL swaps the order of execution of WebFrameTestClient::WillSendRequest and
the part where FirstPartyForCookies and RequestorOrigin are set.

FirstPartyForCookies is used in WebFrameTestClient::WillSendRequest.
Using the wrong order caused the following test to fail:
TEST=
 * external/wpt/url/failure.html
 * fast/loader/main-document-url-for-non-http-loads.html
 * http/tests/cache/iframe-304-crash.html
 * http/tests/history/post-replace-state-reload.html
 * http/tests/inspector/network/network-datareceived.html
 * http/tests/inspector/resource-parameters-ipv6.html
 * http/tests/loading/307-after-303-after-post.html
 * http/tests/loading/redirect-methods.html
 * http/tests/misc/window-dot-stop.html
 * http/tests/navigation/location-reload-after-post.php

BUG=735424

Review-Url: https://codereview.chromium.org/2953583002
Cr-Commit-Position: refs/heads/master@{#482621}
Committed:
https://chromium.googlesource.com/chromium/src/+/f06bfc089846a2175801cf7d249f...
==========

[commit-bot: I haz the power, 2017-06-27 14:34:18]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f06bfc089846a2175801cf7d249f...