Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 2953573002: Photo Picker dialog: Fix possible crash in closeRequest when decoding fails. (Closed)

Created:
3 years, 6 months ago by Finnur
Modified:
3 years, 6 months ago
Reviewers:
Theresa
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Photo Picker dialog: Fix possible crash in closeRequest when decoding fails. BUG=735457, 656015 Review-Url: https://codereview.chromium.org/2953573002 Cr-Commit-Position: refs/heads/master@{#481230} Committed: https://chromium.googlesource.com/chromium/src/+/9300b027733c50637cdf6bc3668f432c598c7a68

Patch Set 1 #

Patch Set 2 : Polish #

Patch Set 3 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/photo_picker/DecoderServiceHost.java View 1 2 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 22 (15 generated)
Finnur
3 years, 6 months ago (2017-06-21 15:09:38 UTC) #6
Theresa
lgtm
3 years, 6 months ago (2017-06-21 15:16:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2953573002/20001
3 years, 6 months ago (2017-06-21 15:21:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2953573002/20001
3 years, 6 months ago (2017-06-21 15:24:15 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/295120)
3 years, 6 months ago (2017-06-21 16:03:41 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2953573002/40001
3 years, 6 months ago (2017-06-21 16:23:20 UTC) #19
commit-bot: I haz the power
3 years, 6 months ago (2017-06-21 17:21:49 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9300b027733c50637cdf6bc3668f...

Powered by Google App Engine
This is Rietveld 408576698