|
|
Chromium Code Reviews
DescriptionPhoto Picker dialog: Fix possible crash in closeRequest when decoding fails.
BUG=735457, 656015
Review-Url: https://codereview.chromium.org/2953573002
Cr-Commit-Position: refs/heads/master@{#481230}
Committed: https://chromium.googlesource.com/chromium/src/+/9300b027733c50637cdf6bc3668f432c598c7a68
Patch Set 1 #Patch Set 2 : Polish #Patch Set 3 : Fix #Messages
Total messages: 22 (15 generated)
The CQ bit was checked by finnur@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by finnur@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
finnur@chromium.org changed reviewers: + twellington@chromium.org
lgtm
The CQ bit was unchecked by finnur@chromium.org
The CQ bit was checked by finnur@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Photo Picker dialog: Fix possible crash in closeRequest when decoding fails. BUG=735457 ========== to ========== Photo Picker dialog: Fix possible crash in closeRequest when decoding fails. BUG=735457, 656015 ==========
The CQ bit was unchecked by finnur@chromium.org
The CQ bit was checked by finnur@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
The CQ bit was checked by finnur@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from twellington@chromium.org Link to the patchset: https://codereview.chromium.org/2953573002/#ps40001 (title: "Fix")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1498062184473700,
"parent_rev": "38cde60a4b6cd9c61a668d70a14d37cd88bd5cc5", "commit_rev":
"9300b027733c50637cdf6bc3668f432c598c7a68"}
Message was sent while issue was closed.
Description was changed from ========== Photo Picker dialog: Fix possible crash in closeRequest when decoding fails. BUG=735457, 656015 ========== to ========== Photo Picker dialog: Fix possible crash in closeRequest when decoding fails. BUG=735457, 656015 Review-Url: https://codereview.chromium.org/2953573002 Cr-Commit-Position: refs/heads/master@{#481230} Committed: https://chromium.googlesource.com/chromium/src/+/9300b027733c50637cdf6bc3668f... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/9300b027733c50637cdf6bc3668f... |
