Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2953513003: RTCPeerConnectionHandler using WebRtcMediaStreamAdapterMap. (Closed)

Created:
3 years, 6 months ago by hbos_chromium
Modified:
3 years, 5 months ago
Reviewers:
Guido Urdaneta
CC:
chromium-reviews, posciak+watch_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

RTCPeerConnectionHandler using WebRtcMediaStreamAdapterMap. Instead of local_streams_ owning the adapters, the map owns them and local_streams_ references stream adapters. This makes it possible for local stream adapters to exist that are not part of the local_streams_ vector. This unblocks addTrack, which will require senders to reference streams (stream adapters) that may not necessarily be part of local_streams_. BUG=700916, 705901 Review-Url: https://codereview.chromium.org/2953513003 Cr-Commit-Position: refs/heads/master@{#482292} Committed: https://chromium.googlesource.com/chromium/src/+/72f065897118a459b71ed840e5b9b22883ddaf5d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -12 lines) Patch
M content/renderer/media/rtc_peer_connection_handler.h View 3 chunks +13 lines, -2 lines 0 comments Download
M content/renderer/media/rtc_peer_connection_handler.cc View 5 chunks +12 lines, -10 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (10 generated)
hbos_chromium
Please take a look, guidou.
3 years, 6 months ago (2017-06-21 13:31:50 UTC) #5
Guido Urdaneta
lgtm
3 years, 5 months ago (2017-06-26 10:17:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2953513003/20001
3 years, 5 months ago (2017-06-26 15:24:40 UTC) #10
commit-bot: I haz the power
3 years, 5 months ago (2017-06-26 16:38:19 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/72f065897118a459b71ed840e5b9...

Powered by Google App Engine
This is Rietveld 408576698