Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(899)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2953503002: Only set types of conditional expressions in strong mode. (Closed)

Created:
3 years, 6 months ago by Paul Berry
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Only set types of conditional expressions in strong mode. In spec mode the types aren't meaningful anyway (due to the fact that the spec mode type system is unsound), and they don't match the behavior of Rasta (causing bot failures). R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/5dd84a802e327e2d4c80350a08156b8292b1fb9b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+921 lines, -781 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart View 1 chunk +1 line, -4 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart View 6 chunks +24 lines, -9 lines 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart View 2 chunks +6 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/escape.dart.direct.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/expressions.dart.direct.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/conditional_lub.dart.direct.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/conditional_upwards_inference.dart.direct.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/infer_assign_to_implicit_this.dart.direct.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_assign_to_implicit_this.dart.strong.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_assign_to_implicit_this_upwards.dart.direct.expect View 3 chunks +7 lines, -7 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_assign_to_implicit_this_upwards.dart.strong.expect View 3 chunks +7 lines, -7 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_assign_to_index_full.dart.direct.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_assign_to_index_full.dart.strong.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_assign_to_index_set_vs_get.dart.direct.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_assign_to_index_set_vs_get.dart.strong.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_assign_to_index_super.dart.direct.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_assign_to_index_super.dart.strong.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_assign_to_index_super_upwards.dart.direct.expect View 9 chunks +21 lines, -21 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_assign_to_index_super_upwards.dart.strong.expect View 9 chunks +21 lines, -21 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_assign_to_index_this.dart.direct.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_assign_to_index_this.dart.strong.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_assign_to_index_this_upwards.dart.direct.expect View 9 chunks +21 lines, -21 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_assign_to_index_this_upwards.dart.strong.expect View 9 chunks +21 lines, -21 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_assign_to_index_upwards.dart.direct.expect View 9 chunks +21 lines, -21 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_assign_to_index_upwards.dart.strong.expect View 9 chunks +21 lines, -21 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_assign_to_local.dart.direct.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_assign_to_local.dart.strong.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_assign_to_local_upwards.dart.direct.expect View 3 chunks +7 lines, -7 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_assign_to_local_upwards.dart.strong.expect View 3 chunks +7 lines, -7 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_assign_to_property_full.dart.direct.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_assign_to_property_full.dart.strong.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_assign_to_property_null_aware.dart.direct.expect View 1 chunk +14 lines, -14 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_assign_to_property_null_aware.dart.strong.expect View 1 chunk +14 lines, -14 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_assign_to_property_null_aware_upwards.dart.direct.expect View 3 chunks +28 lines, -28 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_assign_to_property_null_aware_upwards.dart.strong.expect View 3 chunks +28 lines, -28 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_assign_to_property_super.dart.direct.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_assign_to_property_super.dart.strong.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_assign_to_property_super_upwards.dart.direct.expect View 3 chunks +7 lines, -7 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_assign_to_property_super_upwards.dart.strong.expect View 3 chunks +7 lines, -7 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_assign_to_property_upwards.dart.direct.expect View 3 chunks +7 lines, -7 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_assign_to_property_upwards.dart.strong.expect View 3 chunks +7 lines, -7 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_assign_to_static.dart.direct.expect View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_assign_to_static.dart.strong.expect View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_assign_to_static_upwards.dart.direct.expect View 3 chunks +7 lines, -7 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_assign_to_static_upwards.dart.strong.expect View 3 chunks +7 lines, -7 lines 0 comments Download
M pkg/front_end/testcases/inference/null_aware_method_invocation.dart.direct.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/null_aware_property_get.dart.direct.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference_new/infer_instance_accessor_ref.dart.direct.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference_new/infer_instance_accessor_ref.dart.strong.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference_new/infer_instance_field_ref.dart.direct.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference_new/infer_instance_field_ref.dart.strong.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference_new/strongly_connected_component.dart.direct.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/micro.dart.direct.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/null_aware.dart.direct.expect View 1 chunk +7 lines, -7 lines 0 comments Download
M pkg/front_end/testcases/optional.dart.direct.expect View 2 chunks +7 lines, -7 lines 0 comments Download
M pkg/front_end/testcases/override.dart.direct.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/rasta/bad_constructor_redirection.dart.direct.expect View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/front_end/testcases/rasta/bad_default_constructor.dart.direct.expect View 1 chunk +14 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/rasta/bad_explicit_super_constructor.dart.direct.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/rasta/bad_implicit_super_constructor.dart.direct.expect View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/front_end/testcases/rasta/bad_redirection.dart.direct.expect View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/front_end/testcases/rasta/bad_setter_initializer.dart.direct.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/rasta/bad_unicode.dart.direct.expect View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/rasta/breaking_bad.dart.direct.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/rasta/class_hierarchy.dart.direct.expect View 1 chunk +8 lines, -13 lines 0 comments Download
M pkg/front_end/testcases/rasta/deferred_load.dart.direct.expect View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/front_end/testcases/rasta/duplicated_mixin.dart.direct.expect View 1 chunk +11 lines, -3 lines 0 comments Download
M pkg/front_end/testcases/rasta/issue_000031.dart.direct.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/rasta/issue_000032.dart.direct.expect View 1 chunk +6 lines, -1 line 0 comments Download
M pkg/front_end/testcases/rasta/issue_000034.dart.direct.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/rasta/issue_000035.dart.direct.expect View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/front_end/testcases/rasta/issue_000035a.dart.direct.expect View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/front_end/testcases/rasta/issue_000036.dart.direct.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/rasta/issue_000039.dart.direct.expect View 1 chunk +10 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/rasta/issue_000041.dart.direct.expect View 1 chunk +3 lines, -5 lines 0 comments Download
M pkg/front_end/testcases/rasta/issue_000044.dart.direct.expect View 1 chunk +8 lines, -10 lines 0 comments Download
M pkg/front_end/testcases/rasta/issue_000045.dart.direct.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/rasta/issue_000046.dart.direct.expect View 1 chunk +6 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/rasta/issue_000047.dart.direct.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/rasta/malformed_const_constructor.dart.direct.expect View 1 chunk +9 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/rasta/malformed_function.dart.direct.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/rasta/mixin_library.dart.direct.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/rasta/native_is_illegal.dart.direct.expect View 1 chunk +10 lines, -11 lines 0 comments Download
M pkg/front_end/testcases/rasta/parser_error.dart.direct.expect View 1 chunk +7 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/rasta/static.dart.direct.expect View 1 chunk +10 lines, -10 lines 0 comments Download
M pkg/front_end/testcases/rasta/super.dart.direct.expect View 5 chunks +176 lines, -180 lines 0 comments Download
M pkg/front_end/testcases/rasta/super_mixin.dart.direct.expect View 1 chunk +92 lines, -21 lines 0 comments Download
M pkg/front_end/testcases/rasta/super_operator.dart.direct.expect View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/front_end/testcases/rasta/type_literals.dart.direct.expect View 1 chunk +66 lines, -66 lines 0 comments Download
M pkg/front_end/testcases/rasta/type_with_parse_error.dart.direct.expect View 1 chunk +15 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/rasta/typedef.dart.direct.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/rasta/unresolved_for_in.dart.direct.expect View 2 chunks +13 lines, -19 lines 0 comments Download
M pkg/front_end/testcases/rasta/unresolved_recovery.dart.direct.expect View 1 chunk +16 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/super_rasta_copy.dart.direct.expect View 1 chunk +22 lines, -22 lines 0 comments Download
M pkg/front_end/testcases/type_variable_as_super.dart.direct.expect View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/front_end/testcases/void-methods.dart.direct.expect View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 6 months ago (2017-06-20 21:51:37 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 6 months ago (2017-06-20 21:57:25 UTC) #3
Paul Berry
3 years, 6 months ago (2017-06-20 21:59:35 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
5dd84a802e327e2d4c80350a08156b8292b1fb9b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698