Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: pkg/front_end/lib/src/fasta/kernel/body_builder.dart

Issue 2953503002: Only set types of conditional expressions in strong mode. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/front_end/lib/src/fasta/kernel/body_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/kernel/body_builder.dart b/pkg/front_end/lib/src/fasta/kernel/body_builder.dart
index fb18875ccece743e4bf35e8adc36dd3216c07591..b72a32c9fd9dad26d3757ed4a5163107f437b85b 100644
--- a/pkg/front_end/lib/src/fasta/kernel/body_builder.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/body_builder.dart
@@ -866,10 +866,11 @@ class BodyBuilder extends ScopeListener<JumpTarget> implements BuilderHelper {
VariableDeclaration variable = new VariableDeclaration.forValue(a);
push(new KernelIfNullExpression(
variable,
- new KernelConditionalExpression(
+ new ConditionalExpression(
buildIsNull(new VariableGet(variable), offsetForToken(token)),
b,
- new VariableGet(variable))));
+ new VariableGet(variable),
+ null)));
}
/// Handle `a?.b(...)`.
@@ -3202,7 +3203,7 @@ class BodyBuilder extends ScopeListener<JumpTarget> implements BuilderHelper {
new NullLiteral(),
new MethodInvocation(new VariableGet(variable), name, arguments)
..fileOffset = offset,
- const DynamicType())
+ null)
..fileOffset = offset)
..fileOffset = offset;
} else {
« no previous file with comments | « no previous file | pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698