Add LayoutTheme::PlatformActiveSpellingMarkerHighlightColor()

Add LayoutTheme::PlatformActiveSpellingMarkerHighlightColor()

I'm working on adding support for the Android spellcheck menu in
https://codereview.chromium.org/2931443003

and we need to add another color to LayoutTheme to represent what color we
should highlight a misspelled word while the menu is active. Android uses the
same red color as the spellcheck underline but with some transparency added. We
decided that it's better to add a separate method to LayoutTheme for getting the
color than to assume that we'll want to do an alpha blend on every platform that
might ever support this menu.

BUG=715365
Review-Url: https://codereview.chromium.org/2953493002
Cr-Commit-Position: refs/heads/master@{#481085}
Committed: https://chromium.googlesource.com/chromium/src/+/c0e31689b5b37b8f128db8b8475fa7744e675d47

[rlanday, 2017-06-20 21:35:39]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[rlanday, 2017-06-20 21:36:01]

rlanday@chromium.org changed reviewers:
+ chrishtr@chromium.org

[commit-bot: I haz the power, 2017-06-20 21:36:09]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rlanday, 2017-06-20 21:36:20]

rlanday@chromium.org changed reviewers:
+ yosin@google.com

[rlanday, 2017-06-20 21:36:20]

rlanday@chromium.org changed required reviewers:
+ chrishtr@chromium.org

[rlanday, 2017-06-20 21:36:50]

rlanday@chromium.org changed reviewers:
+ yosin@chromium.org
- chrishtr@chromium.org, yosin@google.com

[rlanday, 2017-06-20 21:36:50]

rlanday@chromium.org changed required reviewers:
- chrishtr@chromium.org

[rlanday, 2017-06-20 21:36:56]

rlanday@chromium.org changed reviewers:
+ tkent@chromium.org

[tkent, 2017-06-20 23:31:08]

lgtm

https://codereview.chromium.org/2953493002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutTheme.h (right):

https://codereview.chromium.org/2953493002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutTheme.h:136: virtual Color
PlatformActiveSpellingMarkerHighlightColor() const;
We don't need to add |virtual| to a function which no one overrides.

[rlanday, 2017-06-20 23:47:19]

https://codereview.chromium.org/2953493002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutTheme.h (right):

https://codereview.chromium.org/2953493002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutTheme.h:136: virtual Color
PlatformActiveSpellingMarkerHighlightColor() const;
On 2017/06/20 at 23:31:08, tkent wrote:
> We don't need to add |virtual| to a function which no one overrides.

Someday, maybe :)

Updated

[rlanday, 2017-06-20 23:47:23]

The CQ bit was checked by rlanday@chromium.org

[rlanday, 2017-06-20 23:47:24]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/2953493002/#ps20001
(title: "Remove virtual")

[commit-bot: I haz the power, 2017-06-20 23:47:48]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-06-21 01:21:04]

lgtm Thanks!

[commit-bot: I haz the power, 2017-06-21 02:17:20]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498002443994660,
"parent_rev": "ddd1c408d37adc96182b9ed1cce769c160bdaabe", "commit_rev":
"c0e31689b5b37b8f128db8b8475fa7744e675d47"}

[commit-bot: I haz the power, 2017-06-21 02:17:31]

Description was changed from

==========
Add LayoutTheme::PlatformActiveSpellingMarkerHighlightColor()

I'm working on adding support for the Android spellcheck menu in
https://codereview.chromium.org/2931443003

and we need to add another color to LayoutTheme to represent what color we
should highlight a misspelled word while the menu is active. Android uses the
same red color as the spellcheck underline but with some transparency added. We
decided that it's better to add a separate method to LayoutTheme for getting the
color than to assume that we'll want to do an alpha blend on every platform that
might ever support this menu.

BUG=715365
==========

to

==========
Add LayoutTheme::PlatformActiveSpellingMarkerHighlightColor()

I'm working on adding support for the Android spellcheck menu in
https://codereview.chromium.org/2931443003

and we need to add another color to LayoutTheme to represent what color we
should highlight a misspelled word while the menu is active. Android uses the
same red color as the spellcheck underline but with some transparency added. We
decided that it's better to add a separate method to LayoutTheme for getting the
color than to assume that we'll want to do an alpha blend on every platform that
might ever support this menu.

BUG=715365

Review-Url: https://codereview.chromium.org/2953493002
Cr-Commit-Position: refs/heads/master@{#481085}
Committed:
https://chromium.googlesource.com/chromium/src/+/c0e31689b5b37b8f128db8b8475f...
==========

[commit-bot: I haz the power, 2017-06-21 02:17:32]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c0e31689b5b37b8f128db8b8475f...