Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: PRESUBMIT.py

Issue 2953473002: Use leveldb_env::OpenDB() to open leveldb databases. (Closed)
Patch Set: Rebase; add comments to CHECK() Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/history_report/delta_file_backend_leveldb.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 3a6ab4a4aeab15f039c6a8ddaa5a72f5d362de31..9ffa555eaa1849b604f3d52c82d1e6d5b1de808a 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -383,6 +383,18 @@ _BANNED_CPP_FUNCTIONS = (
r'^content[\\\/]public[\\\/]test[\\\/]test_web_ui\.(cc|h)$',
),
),
+ (
+ 'leveldb::DB::Open',
+ (
+ 'Instead of leveldb::DB::Open() use leveldb_env::OpenDB() from',
+ 'third_party/leveldatabase/env_chromium.h. It exposes databases to',
+ "Chrome's tracing, making their memory usage visible.",
+ ),
+ True,
+ (
+ r'^third_party/leveldatabase/.*\.(cc|h)$',
+ ),
+ )
)
« no previous file with comments | « no previous file | chrome/browser/android/history_report/delta_file_backend_leveldb.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698