| OLD | NEW |
| 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. |
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
| 4 | 4 |
| 5 """Top-level presubmit script for Chromium. | 5 """Top-level presubmit script for Chromium. |
| 6 | 6 |
| 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts | 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts |
| 8 for more details about the presubmit API built into depot_tools. | 8 for more details about the presubmit API built into depot_tools. |
| 9 """ | 9 """ |
| 10 | 10 |
| (...skipping 365 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 376 'AllowJavascript(), OnJavascriptAllowed()/OnJavascriptDisallowed(),', | 376 'AllowJavascript(), OnJavascriptAllowed()/OnJavascriptDisallowed(),', |
| 377 'and CallJavascriptFunction(). See https://goo.gl/qivavq.', | 377 'and CallJavascriptFunction(). See https://goo.gl/qivavq.', |
| 378 ), | 378 ), |
| 379 False, | 379 False, |
| 380 ( | 380 ( |
| 381 r'^content[\\\/]browser[\\\/]webui[\\\/]web_ui_impl\.(cc|h)$', | 381 r'^content[\\\/]browser[\\\/]webui[\\\/]web_ui_impl\.(cc|h)$', |
| 382 r'^content[\\\/]public[\\\/]browser[\\\/]web_ui\.h$', | 382 r'^content[\\\/]public[\\\/]browser[\\\/]web_ui\.h$', |
| 383 r'^content[\\\/]public[\\\/]test[\\\/]test_web_ui\.(cc|h)$', | 383 r'^content[\\\/]public[\\\/]test[\\\/]test_web_ui\.(cc|h)$', |
| 384 ), | 384 ), |
| 385 ), | 385 ), |
| 386 ( |
| 387 'leveldb::DB::Open', |
| 388 ( |
| 389 'Instead of leveldb::DB::Open() use leveldb_env::OpenDB() from', |
| 390 'third_party/leveldatabase/env_chromium.h. It exposes databases to', |
| 391 "Chrome's tracing, making their memory usage visible.", |
| 392 ), |
| 393 True, |
| 394 ( |
| 395 r'^third_party/leveldatabase/.*\.(cc|h)$', |
| 396 ), |
| 397 ) |
| 386 ) | 398 ) |
| 387 | 399 |
| 388 | 400 |
| 389 _IPC_ENUM_TRAITS_DEPRECATED = ( | 401 _IPC_ENUM_TRAITS_DEPRECATED = ( |
| 390 'You are using IPC_ENUM_TRAITS() in your code. It has been deprecated.\n' | 402 'You are using IPC_ENUM_TRAITS() in your code. It has been deprecated.\n' |
| 391 'See http://www.chromium.org/Home/chromium-security/education/security-tips-
for-ipc') | 403 'See http://www.chromium.org/Home/chromium-security/education/security-tips-
for-ipc') |
| 392 | 404 |
| 393 | 405 |
| 394 _VALID_OS_MACROS = ( | 406 _VALID_OS_MACROS = ( |
| 395 # Please keep sorted. | 407 # Please keep sorted. |
| (...skipping 2016 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 2412 output_api, | 2424 output_api, |
| 2413 json_url='http://chromium-status.appspot.com/current?format=json')) | 2425 json_url='http://chromium-status.appspot.com/current?format=json')) |
| 2414 | 2426 |
| 2415 results.extend( | 2427 results.extend( |
| 2416 input_api.canned_checks.CheckPatchFormatted(input_api, output_api)) | 2428 input_api.canned_checks.CheckPatchFormatted(input_api, output_api)) |
| 2417 results.extend(input_api.canned_checks.CheckChangeHasBugField( | 2429 results.extend(input_api.canned_checks.CheckChangeHasBugField( |
| 2418 input_api, output_api)) | 2430 input_api, output_api)) |
| 2419 results.extend(input_api.canned_checks.CheckChangeHasDescription( | 2431 results.extend(input_api.canned_checks.CheckChangeHasDescription( |
| 2420 input_api, output_api)) | 2432 input_api, output_api)) |
| 2421 return results | 2433 return results |
| OLD | NEW |