Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1098)

Issue 2953463002: config_service: integrated working config set page with routing (Closed)

Created:
3 years, 6 months ago by cwpayton
Modified:
3 years, 6 months ago
Reviewers:
Sergey Berezin, hinoka
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

config_service: integrated working config set page with routing The config-set-card elements on the front page now redirect to config-set pages that list the files of the config set. Currently the config-file-cards all link to gitiles. BUG=730832 Review-Url: https://codereview.chromium.org/2953463002 Committed: https://github.com/luci/luci-py/commit/51155047e84961268eeffdfa2ec8a595ed4c21b4

Patch Set 1 #

Patch Set 2 : Nit: fixed 80+ char line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -6 lines) Patch
A appengine/config_service/ui/src/config-ui/config-file-card.html View 1 chunk +43 lines, -0 lines 0 comments Download
A appengine/config_service/ui/src/config-ui/config-set.html View 1 1 chunk +104 lines, -0 lines 0 comments Download
M appengine/config_service/ui/src/config-ui/config-ui.html View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
cwpayton
PTAL
3 years, 6 months ago (2017-06-20 18:15:56 UTC) #2
Sergey Berezin
The code looks good. Could you link to screenshots, or upload a version to the ...
3 years, 6 months ago (2017-06-20 21:31:37 UTC) #4
cwpayton
Demo of the config set page can be found here: https://2916-5fee7ae-tainted-cwpayton-dot-luci-config-dev.appspot.com/newui#/
3 years, 6 months ago (2017-06-20 21:35:50 UTC) #5
Sergey Berezin
LGTM, thanks!
3 years, 6 months ago (2017-06-21 00:42:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2953463002/20001
3 years, 6 months ago (2017-06-21 15:40:24 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-21 15:42:40 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-py/commit/51155047e84961268eeffdfa2ec8a595ed4c21b4

Powered by Google App Engine
This is Rietveld 408576698