Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2953423002: Add type inference for switch statements. (Closed)

Created:
3 years, 6 months ago by Paul Berry
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add type inference for switch statements. Analyzer does not infer switch cases correctly (it uses an empty context for the case expression, instead of the type of the switch expression), so the tests are in inference_new. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/b94fdceadceff70622673bc57d0f1e9c9d0ab011

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -12 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 8 chunks +12 lines, -12 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart View 2 chunks +32 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_inference_listener.dart View 2 chunks +12 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference_new/switch.dart View 1 chunk +25 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference_new/switch.dart.direct.expect View 1 chunk +29 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference_new/switch.dart.outline.expect View 1 chunk +14 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference_new/switch.dart.strong.expect View 1 chunk +29 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/kompile.status View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
I only need a review from one of you. This is not urgent--feel free to ...
3 years, 6 months ago (2017-06-25 15:45:41 UTC) #2
scheglov
LGTM
3 years, 5 months ago (2017-06-26 15:11:31 UTC) #3
Paul Berry
3 years, 5 months ago (2017-06-26 15:49:09 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b94fdceadceff70622673bc57d0f1e9c9d0ab011 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698