Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Unified Diff: pkg/front_end/lib/src/fasta/kernel/body_builder.dart

Issue 2953423002: Add type inference for switch statements. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/front_end/lib/src/fasta/kernel/body_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/kernel/body_builder.dart b/pkg/front_end/lib/src/fasta/kernel/body_builder.dart
index 304165bd5bc5dbaa6a5091a9872cab7ca21e9932..de0e5878ffe0914e597eecf50645e90e6d11fba1 100644
--- a/pkg/front_end/lib/src/fasta/kernel/body_builder.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/body_builder.dart
@@ -1508,7 +1508,7 @@ class BodyBuilder extends ScopeListener<JumpTarget> implements BuilderHelper {
JumpTarget continueTarget = exitContinueTarget();
JumpTarget breakTarget = exitBreakTarget();
if (continueTarget.hasUsers) {
- body = new LabeledStatement(body);
+ body = new KernelLabeledStatement(body);
continueTarget.resolveContinues(body);
}
Statement result =
@@ -1517,7 +1517,7 @@ class BodyBuilder extends ScopeListener<JumpTarget> implements BuilderHelper {
result = new Block(<Statement>[begin, result]);
}
if (breakTarget.hasUsers) {
- result = new LabeledStatement(result);
+ result = new KernelLabeledStatement(result);
breakTarget.resolveBreaks(result);
}
exitLoopOrSwitch(result);
@@ -2488,12 +2488,12 @@ class BodyBuilder extends ScopeListener<JumpTarget> implements BuilderHelper {
JumpTarget continueTarget = exitContinueTarget();
JumpTarget breakTarget = exitBreakTarget();
if (continueTarget.hasUsers) {
- body = new LabeledStatement(body);
+ body = new KernelLabeledStatement(body);
continueTarget.resolveContinues(body);
}
Statement result = new DoStatement(body, condition);
if (breakTarget.hasUsers) {
- result = new LabeledStatement(result);
+ result = new KernelLabeledStatement(result);
breakTarget.resolveBreaks(result);
}
exitLoopOrSwitch(result);
@@ -2523,7 +2523,7 @@ class BodyBuilder extends ScopeListener<JumpTarget> implements BuilderHelper {
JumpTarget continueTarget = exitContinueTarget();
JumpTarget breakTarget = exitBreakTarget();
if (continueTarget.hasUsers) {
- body = new LabeledStatement(body);
+ body = new KernelLabeledStatement(body);
continueTarget.resolveContinues(body);
}
VariableDeclaration variable;
@@ -2560,7 +2560,7 @@ class BodyBuilder extends ScopeListener<JumpTarget> implements BuilderHelper {
isAsync: awaitToken != null)
..fileOffset = body.fileOffset;
if (breakTarget.hasUsers) {
- result = new LabeledStatement(result);
+ result = new KernelLabeledStatement(result);
breakTarget.resolveBreaks(result);
}
exitLoopOrSwitch(result);
@@ -2594,13 +2594,13 @@ class BodyBuilder extends ScopeListener<JumpTarget> implements BuilderHelper {
exitLocalScope();
if (target.breakTarget.hasUsers) {
if (statement is! LabeledStatement) {
- statement = new LabeledStatement(statement);
+ statement = new KernelLabeledStatement(statement);
}
target.breakTarget.resolveBreaks(statement);
}
if (target.continueTarget.hasUsers) {
if (statement is! LabeledStatement) {
- statement = new LabeledStatement(statement);
+ statement = new KernelLabeledStatement(statement);
}
target.continueTarget.resolveContinues(statement);
}
@@ -2634,12 +2634,12 @@ class BodyBuilder extends ScopeListener<JumpTarget> implements BuilderHelper {
JumpTarget continueTarget = exitContinueTarget();
JumpTarget breakTarget = exitBreakTarget();
if (continueTarget.hasUsers) {
- body = new LabeledStatement(body);
+ body = new KernelLabeledStatement(body);
continueTarget.resolveContinues(body);
}
Statement result = new WhileStatement(condition, body);
if (breakTarget.hasUsers) {
- result = new LabeledStatement(result);
+ result = new KernelLabeledStatement(result);
breakTarget.resolveBreaks(result);
}
exitLoopOrSwitch(result);
@@ -2834,9 +2834,9 @@ class BodyBuilder extends ScopeListener<JumpTarget> implements BuilderHelper {
exitSwitchScope();
exitLocalScope();
Expression expression = popForValue();
- Statement result = new SwitchStatement(expression, cases);
+ Statement result = new KernelSwitchStatement(expression, cases);
if (target.hasUsers) {
- result = new LabeledStatement(result);
+ result = new KernelLabeledStatement(result);
target.resolveBreaks(result);
}
exitLoopOrSwitch(result);
« no previous file with comments | « no previous file | pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698