Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Issue 2953393002: android WCG support: Add missing plumbing (Closed)

Created:
3 years, 6 months ago by ccameron
Modified:
3 years, 6 months ago
Reviewers:
hubbe
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

android WCG support: Add missing plumbing Add a stub in populating the display::Display, where we will ultimately decide between P3 and sRGB. The code to detect which is appropriate is not present yet. Populate the cc::RendererSettings::color_correct_rendering and ScreenInfo::color_space fields correctly. TBR=hubbe BUG=735658 Review-Url: https://codereview.chromium.org/2953393002 Cr-Commit-Position: refs/heads/master@{#482169} Committed: https://chromium.googlesource.com/chromium/src/+/fdf3733167497d23d93981188c0599f6d51bda5b

Patch Set 1 #

Patch Set 2 : Fix build #

Patch Set 3 : Fix build again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M content/browser/renderer_host/compositor_impl_android.cc View 3 chunks +8 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_view_android.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/android/display_android_manager.cc View 1 2 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (17 generated)
ccameron
(and more stuff that should have https://codereview.chromium.org/2950183002/)
3 years, 6 months ago (2017-06-25 07:13:57 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2953393002/40001
3 years, 6 months ago (2017-06-25 07:14:11 UTC) #17
commit-bot: I haz the power
3 years, 6 months ago (2017-06-25 07:18:47 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/fdf3733167497d23d93981188c05...

Powered by Google App Engine
This is Rietveld 408576698