Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 2953293002: Chrome Cleaner UI: Add a new logs upload permission string (Closed)

Created:
3 years, 6 months ago by alito
Modified:
3 years, 6 months ago
CC:
chromium-reviews, srahim+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Chrome Cleaner UI: Add a new logs upload permission string BUG=736465 TBR=grt@chromium.org Review-Url: https://codereview.chromium.org/2953293002 Cr-Commit-Position: refs/heads/master@{#482036} Committed: https://chromium.googlesource.com/chromium/src/+/af4db795bb4122a7d352b69a3b7a715241562a6e

Patch Set 1 #

Total comments: 1

Patch Set 2 : Changed to a different preferred string #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/app/generated_resources.grd View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
alito
PTAL!
3 years, 6 months ago (2017-06-23 19:20:59 UTC) #2
proberge
lgtm https://codereview.chromium.org/2953293002/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/2953293002/diff/1/chrome/app/generated_resources.grd#newcode6460 chrome/app/generated_resources.grd:6460: Send information about your computer's settings and applications ...
3 years, 6 months ago (2017-06-23 19:23:35 UTC) #3
robertshield
lgtm
3 years, 6 months ago (2017-06-23 20:16:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2953293002/20001
3 years, 6 months ago (2017-06-23 20:17:17 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-23 21:27:26 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/af4db795bb4122a7d352b69a3b7a...

Powered by Google App Engine
This is Rietveld 408576698