Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2953263002: Revert of Reland: Refactor DeviceMotionEventPump to use //device/generic_sensor instead of //device/sensors (Closed)

Created:
3 years, 6 months ago by juncai
Modified:
3 years, 6 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, shalamov, Peter Beverloo, riju_, blink-reviews, mlamouri+watch-blink_chromium.org, dglazkov+blink, darin-cc_chromium.org, wanming.lin, mlamouri+watch-sensors_chromium.org, haraken, einbinder+watch-test-runner_chromium.org, blink-reviews-api_chromium.org, jochen+watch_chromium.org, Mikhail
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reland: Refactor DeviceMotionEventPump to use //device/generic_sensor instead of //device/sensors (patchset #14 id:260001 of https://codereview.chromium.org/2896583005/ ) Reason for revert: Need to figure out some issues related to this CL on Windows. To reland, need to add tests on Android and Mac, and fix the issue on Windows. Original issue's description: > Refactor DeviceMotionEventPump to use //device/generic_sensor instead of //device/sensors > > //device/generic_sensors already has all the sensors that can be used > to implement the DeviceOrientation event: > https://w3c.github.io/deviceorientation/spec-source-orientation.html > > Currently, //content/renderer/device_sensors uses sensors from > //device/sensors as its backend, and this is one of the CLs that refactor > //content/renderer/device_sensors to use sensors from > //device/generic_sensor as the backend and removes //device/sensors. > > This CL refactors DeviceMotionEvent to use sensors from //device/generic_sensor. > > The issue page contains the design doc link for this change. > > BUG=721427 > > Review-Url: https://codereview.chromium.org/2896583005 > Cr-Original-Commit-Position: refs/heads/master@{#480934} > Committed: https://chromium.googlesource.com/chromium/src/+/687e6a76c9d634404eb93643ab900596a77958fd > Review-Url: https://codereview.chromium.org/2896583005 > Cr-Commit-Position: refs/heads/master@{#481791} > Committed: https://chromium.googlesource.com/chromium/src/+/33f72bfe8b9364e82990f92befa041a08d465d3c TBR=reillyg@chromium.org,timvolodine@chromium.org,jam@chromium.org,scheib@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=721427 Review-Url: https://codereview.chromium.org/2953263002 Cr-Commit-Position: refs/heads/master@{#481945} Committed: https://chromium.googlesource.com/chromium/src/+/56acd30f49c6817b8f1dfd1f25255bf6f89460e5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -839 lines) Patch
M content/browser/device_sensors/device_sensor_browsertest.cc View 14 chunks +73 lines, -214 lines 0 comments Download
M content/renderer/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/device_sensors/device_motion_event_pump.h View 1 chunk +17 lines, -84 lines 0 comments Download
M content/renderer/device_sensors/device_motion_event_pump.cc View 1 chunk +14 lines, -305 lines 0 comments Download
M content/renderer/device_sensors/device_motion_event_pump_unittest.cc View 6 chunks +64 lines, -168 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
D content/test/data/device_sensors/device_motion_only_some_sensors_are_available_test.html View 1 chunk +0 lines, -41 lines 0 comments Download
M content/test/data/device_sensors/device_motion_test.html View 2 chunks +1 line, -2 lines 0 comments Download
M device/generic_sensor/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M device/generic_sensor/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M device/generic_sensor/platform_sensor_provider_android.cc View 1 chunk +1 line, -3 lines 0 comments Download
M device/generic_sensor/sensor_provider_impl.cc View 2 chunks +0 lines, -13 lines 0 comments Download
M services/device/device_service.h View 2 chunks +5 lines, -0 lines 0 comments Download
M services/device/device_service.cc View 5 chunks +25 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
juncai
3 years, 6 months ago (2017-06-23 17:35:19 UTC) #2
Created Revert of Reland: Refactor DeviceMotionEventPump to use
//device/generic_sensor instead of //device/sensors

Powered by Google App Engine
This is Rietveld 408576698