Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2953073004:
[Extensions Bindings] Move loadTypeSchema from utils to json_schema (Closed)
Description[Extensions Bindings] Move loadTypeSchema from utils to json_schema
loadTypeSchema is used in binding.js and json_schema.js, and is
currently defined in utils.js. However, it seems like a better fit in
json_schema itself, since it only deals with schema type loading.
Additionally, we'll likely want to avoid including json_schema et al
with native bindings, so this makes utils safe to include.
BUG=653596
Review-Url: https://codereview.chromium.org/2953073004
Cr-Commit-Position: refs/heads/master@{#483058}
Committed: https://chromium.googlesource.com/chromium/src/+/d634344803d84d26a14cb72df62c3c7182b385f0
Patch Set 1 : . #
Total comments: 2
Patch Set 2 : remove unnecessary require #
Messages
Total messages: 34 (29 generated)
The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Description was changed from ========== loadTypeSchema BUG= ========== to ========== [Extensions Bindings] Move loadTypeSchema from utils to json_schema loadTypeSchema is used in binding.js and json_schema.js, and is currently defined in utils.js. However, it seems like a better fit in json_schema itself, since it only deals with schema type loading. Additionally, we'll likely want to avoid including json_schema et al with native bindings, so this makes utils safe to include. BUG=653596 ==========
The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Patchset #3 (id:40001) has been deleted
Patchset #2 (id:20001) has been deleted
Patchset #1 (id:1) has been deleted
rdevlin.cronin@chromium.org changed reviewers: + lazyboy@chromium.org
lazyboy@, mind taking a look? jbroman@, FYI.
lgtm https://codereview.chromium.org/2953073004/diff/60001/extensions/renderer/res... File extensions/renderer/resources/binding.js (right): https://codereview.chromium.org/2953073004/diff/60001/extensions/renderer/res... extensions/renderer/resources/binding.js:18: var utils = require('utils'); This seems to be unused now?
The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2953073004/diff/60001/extensions/renderer/res... File extensions/renderer/resources/binding.js (right): https://codereview.chromium.org/2953073004/diff/60001/extensions/renderer/res... extensions/renderer/resources/binding.js:18: var utils = require('utils'); On 2017/06/27 17:51:38, lazyboy wrote: > This seems to be unused now? Good catch; removed.
The CQ bit was checked by rdevlin.cronin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from lazyboy@chromium.org Link to the patchset: https://codereview.chromium.org/2953073004/#ps80001 (title: "remove unnecessary require")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1498672874652890,
"parent_rev": "24ddf7e038dd86c52bc1998b83416627e0e9d592", "commit_rev":
"d634344803d84d26a14cb72df62c3c7182b385f0"}
Message was sent while issue was closed.
Description was changed from ========== [Extensions Bindings] Move loadTypeSchema from utils to json_schema loadTypeSchema is used in binding.js and json_schema.js, and is currently defined in utils.js. However, it seems like a better fit in json_schema itself, since it only deals with schema type loading. Additionally, we'll likely want to avoid including json_schema et al with native bindings, so this makes utils safe to include. BUG=653596 ========== to ========== [Extensions Bindings] Move loadTypeSchema from utils to json_schema loadTypeSchema is used in binding.js and json_schema.js, and is currently defined in utils.js. However, it seems like a better fit in json_schema itself, since it only deals with schema type loading. Additionally, we'll likely want to avoid including json_schema et al with native bindings, so this makes utils safe to include. BUG=653596 Review-Url: https://codereview.chromium.org/2953073004 Cr-Commit-Position: refs/heads/master@{#483058} Committed: https://chromium.googlesource.com/chromium/src/+/d634344803d84d26a14cb72df62c... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:80001) as https://chromium.googlesource.com/chromium/src/+/d634344803d84d26a14cb72df62c... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
