Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Unified Diff: third_party/WebKit/Source/core/editing/SurroundingText.cpp

Issue 2952983002: Make Position::FirstPositionInNode() to take const Node& instead of Node* (Closed)
Patch Set: 2017-06-23T10:37:43 Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/SurroundingText.cpp
diff --git a/third_party/WebKit/Source/core/editing/SurroundingText.cpp b/third_party/WebKit/Source/core/editing/SurroundingText.cpp
index 68e561ed1d9a207ce4c87d1c43b4a7af1f8bd5a8..7e9926dd7e6693f3bf58d8d0f66d208bcc7ee036 100644
--- a/third_party/WebKit/Source/core/editing/SurroundingText.cpp
+++ b/third_party/WebKit/Source/core/editing/SurroundingText.cpp
@@ -92,7 +92,7 @@ void SurroundingText::Initialize(const Position& start_position,
// starts at the document's or input element's start and ends at the selection
// start and will be updated.
BackwardsCharacterIterator backwards_iterator(
- Position::FirstPositionInNode(root_element).ParentAnchoredEquivalent(),
+ Position::FirstPositionInNode(*root_element).ParentAnchoredEquivalent(),
start_position,
TextIteratorBehavior::Builder().SetStopsOnFormControls(true).Build());
if (!backwards_iterator.AtEnd())
« no previous file with comments | « third_party/WebKit/Source/core/editing/SelectionEditor.cpp ('k') | third_party/WebKit/Source/core/editing/TextFinder.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698