third_party/WebKit/Source/core/editing/SelectionEditor.cpp - Issue 2952983002: Make Position::FirstPositionInNode() to take const Node& instead of Node*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/SelectionEditor.cpp

Issue 2952983002: Make Position::FirstPositionInNode() to take const Node& instead of Node* (Closed)

Patch Set: 2017-06-23T10:37:43 Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/SelectionEditor.cpp

diff --git a/third_party/WebKit/Source/core/editing/SelectionEditor.cpp b/third_party/WebKit/Source/core/editing/SelectionEditor.cpp

index fdf7cea3a9d9a492eb7d2e2d47b17408efdf6e86..e17c6ee552b1dd7857a0f6fdd0518dadee845f9a 100644

--- a/third_party/WebKit/Source/core/editing/SelectionEditor.cpp

+++ b/third_party/WebKit/Source/core/editing/SelectionEditor.cpp

@@ -177,7 +177,7 @@ static Position ComputePositionForChildrenRemoval(const Position& position,

ContainerNode& container) {

Node* node = position.ComputeContainerNode();

if (container.ContainsIncludingHostElements(*node))

- return Position::FirstPositionInNode(&container);

+ return Position::FirstPositionInNode(container);

return position;

}