Update voice interaction OOBE with new UX spec

Update voice interaction OOBE with new UX spec

Adjust the dialog size, padding and buttons for the voice interaction
value prop and wait for conainer ready screen, in order to be consistent
with other part of voice interaction OOBE flow.

BUG=b/62843626
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2952943002
Cr-Commit-Position: refs/heads/master@{#481730}
Committed: https://chromium.googlesource.com/chromium/src/+/ffc80b382dda2bee490e0fd8ad0b15ea091fba74

[yueli, 2017-06-22 01:13:56]

Description was changed from

==========
Update voice interaction OOBE with new UX spec

Adjust the dialog size, padding and buttons for the voice interaction
value prop and wait for conainer ready screen, in order to be consistent
with other part of voice interaction OOBE flow.

BUG=b/62843626
==========

to

==========
Update voice interaction OOBE with new UX spec

Adjust the dialog size, padding and buttons for the voice interaction
value prop and wait for conainer ready screen, in order to be consistent
with other part of voice interaction OOBE flow.

BUG=b/62843626
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[yueli, 2017-06-22 01:14:23]

updowndota@chromium.org changed reviewers:
+ xiaohuic@chromium.org, xiyuan@chromium.org

[yueli, 2017-06-22 01:14:24]

PTAL

[xiyuan, 2017-06-22 17:15:59]

https://codereview.chromium.org/2952943002/diff/1/chrome/app/chromeos_strings...
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/2952943002/diff/1/chrome/app/chromeos_strings...
chrome/app/chromeos_strings.grdp:6096: <message
name="IDS_VOICE_INTERACTION_VALUE_PROP_NO_THANKS_BUTTON" desc="tmp">
I missed this in previous reviews. All new messages need to have a good
description because that is the only thing visible to the translators. Please
put as detailed as possible description for those message. What are they? Where
do they show? etc. 

Please fix "desc" here and other places. Otherwise, you will get translation
clarification bugs to fix them.

https://codereview.chromium.org/2952943002/diff/1/chrome/app/chromeos_strings...
chrome/app/chromeos_strings.grdp:6097: NO THANKS
How about enforcing this via css
  text-transform: uppercase;
?

[yueli, 2017-06-22 18:37:31]

https://codereview.chromium.org/2952943002/diff/1/chrome/app/chromeos_strings...
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/2952943002/diff/1/chrome/app/chromeos_strings...
chrome/app/chromeos_strings.grdp:6096: <message
name="IDS_VOICE_INTERACTION_VALUE_PROP_NO_THANKS_BUTTON" desc="tmp">
On 2017/06/22 17:15:59, xiyuan wrote:
> I missed this in previous reviews. All new messages need to have a good
> description because that is the only thing visible to the translators. Please
> put as detailed as possible description for those message. What are they?
Where
> do they show? etc. 
> 
> Please fix "desc" here and other places. Otherwise, you will get translation
> clarification bugs to fix them.

Oh! I think I missed it, too. Thank you so much for find it out!

https://codereview.chromium.org/2952943002/diff/1/chrome/app/chromeos_strings...
chrome/app/chromeos_strings.grdp:6097: NO THANKS
On 2017/06/22 17:15:59, xiyuan wrote:
> How about enforcing this via css
>   text-transform: uppercase;
> ?

Done.

[xc, 2017-06-22 18:58:18]

lgtm

[xiyuan, 2017-06-22 19:18:56]

lgtm with the desc fixed.

https://codereview.chromium.org/2952943002/diff/20001/chrome/app/chromeos_str...
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/2952943002/diff/20001/chrome/app/chromeos_str...
chrome/app/chromeos_strings.grdp:6102: <message
name="IDS_WAIT_FOR_CONTAINER_READY_TITLE" desc="tmp">
This needs some care too.

https://codereview.chromium.org/2952943002/diff/20001/chrome/app/chromeos_str...
chrome/app/chromeos_strings.grdp:6105: <message
name="IDS_WAIT_FOR_CONTAINER_READY_INTRO_MESSAGE" desc="tmp">
ditto

[yueli, 2017-06-22 20:43:31]

The CQ bit was checked by updowndota@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-22 20:44:08]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-22 21:08:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-22 21:08:59]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yueli, 2017-06-22 21:13:38]

The CQ bit was checked by updowndota@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-22 21:13:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-22 23:43:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-22 23:43:51]

Dry run: This issue passed the CQ dry run.

[yueli, 2017-06-22 23:55:00]

The CQ bit was checked by updowndota@chromium.org

[yueli, 2017-06-22 23:55:01]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org,
xiaohuic@chromium.org
Link to the patchset: https://codereview.chromium.org/2952943002/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2017-06-22 23:55:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-22 23:58:58]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1498175700947540,
"parent_rev": "62ac5b98d37f0168056e87c2171478fdced0d6db", "commit_rev":
"ffc80b382dda2bee490e0fd8ad0b15ea091fba74"}

[commit-bot: I haz the power, 2017-06-22 23:59:11]

Description was changed from

==========
Update voice interaction OOBE with new UX spec

Adjust the dialog size, padding and buttons for the voice interaction
value prop and wait for conainer ready screen, in order to be consistent
with other part of voice interaction OOBE flow.

BUG=b/62843626
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Update voice interaction OOBE with new UX spec

Adjust the dialog size, padding and buttons for the voice interaction
value prop and wait for conainer ready screen, in order to be consistent
with other part of voice interaction OOBE flow.

BUG=b/62843626
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2952943002
Cr-Commit-Position: refs/heads/master@{#481730}
Committed:
https://chromium.googlesource.com/chromium/src/+/ffc80b382dda2bee490e0fd8ad0b...
==========

[commit-bot: I haz the power, 2017-06-22 23:59:13]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/ffc80b382dda2bee490e0fd8ad0b...