Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(9)

Issue 2952723002: Add keepalive for on screen keyboard (Closed)

Created:
7 months ago by girard
Modified:
3 months, 3 weeks ago
Reviewers:
Peter Kasting, sadrul
CC:
chromium-reviews, jdonnelly+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add keepalive for on screen keyboard BUG=519958

Patch Set 1 #

Patch Set 2 : Cleanup #

Patch Set 3 : Keep OSK on-screen when moving focus to omnibox #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
Trybot results:

Messages

Total messages: 6 (1 generated)
girard
pkasting@chromium.org: Please review changes in omnibox sadrul@chromium.org: Please review changes in osk_display_manager I'm not thrilled ...
7 months ago (2017-06-20 20:05:48 UTC) #2
Peter Kasting
I'm confused why the keyboard is being dismissed to begin with. If the focus appears ...
7 months ago (2017-06-21 02:17:21 UTC) #3
Peter Kasting
What's the status here? Rietveld is deprecated, and I'm looking to ensure my queue here ...
4 months, 3 weeks ago (2017-08-29 04:05:04 UTC) #4
Peter Kasting
FYI, Rietveld becomes fully read-only in one week.
3 months, 4 weeks ago (2017-09-22 06:36:44 UTC) #5
Peter Kasting
3 months, 3 weeks ago (2017-09-29 00:02:11 UTC) #6
Rietveld goes fully read-only tomorrow.  Closing this.  If it's still valuable,
please reopen in Gerrit.

Powered by Google App Engine
This is Rietveld 0eb02b776