Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3473)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java

Issue 2952553002: Dismiss menu when infobar's host tab is hidden. (new translate infobar) (Closed)
Patch Set: use container#removeFromParentView Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java b/chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java
index 8d745a6d7e82f075152ccb8c27bd0d83be4b21b4..35ac20148f12eafeffc23aea02f8349da95781c2 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java
@@ -261,6 +261,14 @@ public class InfoBarContainer extends SwipableOverlayView {
super.addToParentView(mParentView);
}
+ @Override
+ public boolean removeFromParentView() {
+ if (hasInfoBars()) {
+ mInfoBars.get(0).onInfoBarContainerStartedHiding();
mdjones 2017/06/22 19:00:16 Why only index 0?
Marti Wong 2017/06/23 01:39:10 (0) means the top of the infobar stack. only the t
+ }
+ return super.removeFromParentView();
+ }
+
/**
* Adds an InfoBar to the view hierarchy.
* @param infoBar InfoBar to add to the View hierarchy.

Powered by Google App Engine
This is Rietveld 408576698