Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(978)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java

Issue 2952553002: Dismiss menu when infobar's host tab is hidden. (new translate infobar) (Closed)
Patch Set: use container#removeFromParentView Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java b/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java
index 1dc3f014e3602bc77470b23606ee8104b89b0845..0c07be2215100ed4d0c17c251f060a3229f567a9 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java
@@ -430,13 +430,23 @@ public class TranslateCompactInfoBar extends InfoBar
if (mLanguageMenuHelper != null) mLanguageMenuHelper.dismiss();
}
- @Override
- protected void onStartedHiding() {
+ private void dismissMenusAndSnackbars() {
dismissMenus();
if (getSnackbarManager() != null) getSnackbarManager().dismissAllSnackbars();
+ }
+
+ @Override
+ protected void onStartedHiding() {
+ dismissMenusAndSnackbars();
super.onStartedHiding();
}
+ @Override
+ protected void onInfoBarContainerStartedHiding() {
+ dismissMenusAndSnackbars();
+ super.onInfoBarContainerStartedHiding();
+ }
+
/**
* Returns true if overflow menu is showing. This is only used for automation testing.
*/

Powered by Google App Engine
This is Rietveld 408576698