Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 2952543002: Permissions: Update icon and string for the site permission settings infobar. (Closed)

Created:
3 years, 6 months ago by Patti Lor
Modified:
3 years, 6 months ago
Reviewers:
lgarron
CC:
chromium-reviews, lgarron+watch_chromium.org, raymes+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Permissions: Update icon and string for the site permission settings infobar. Update the icon and the string used for the infobar that shows up when changing the site settings via the Page Info bubble. See https://drive.google.com/open?id=0BzEa5HU1aAqBamtNSUlFNTBZM3M for before/after screenshots of the infobar. BUG=734831 TEST=Navigate to https://www.google.com/. Open the Page Info bubble by clicking the "Secure" lock, and change "Location" to "Block". Close the Page Info bubble and observe the infobar's new string and icon. Review-Url: https://codereview.chromium.org/2952543002 Cr-Commit-Position: refs/heads/master@{#481051} Committed: https://chromium.googlesource.com/chromium/src/+/17d7d8d729af2b0f3a73b27a9e2fe9a537a8dfd6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/ui/page_info/page_info_infobar_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/page_info_strings.grdp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
Patti Lor
Hi lgarron@, PTAL? Thanks!
3 years, 6 months ago (2017-06-21 00:43:32 UTC) #7
lgarron
lgtm
3 years, 6 months ago (2017-06-21 00:51:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2952543002/1
3 years, 6 months ago (2017-06-21 00:52:12 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-21 00:57:53 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/17d7d8d729af2b0f3a73b27a9e2f...

Powered by Google App Engine
This is Rietveld 408576698