Issue 2952493002: memory-infra: Fix MemoryDumpScheduler test.

Issue 2952493002: memory-infra: Fix MemoryDumpScheduler test. (Closed)

Created:
3 years, 6 months ago by DmitrySkiba

Modified:
3 years, 6 months ago

Reviewers:
Primiano Tucci (use gerrit)

CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, danakj+watch_chromium.org, vmpstr+watch_chromium.org

Target Ref:
refs/heads/master

Project:
chromium

Visibility:
Public.

memory-infra: Fix MemoryDumpScheduler test. StopAndStartOnAnotherThread was (sometimes) calling mocked function before establishing expectations. TBR=primiano@chromium.org BUG=734810 Review-Url: https://codereview.chromium.org/2952493002 Cr-Commit-Position: refs/heads/master@{#480716} Committed: https://chromium.googlesource.com/chromium/src/+/2b1b0d7374dfeff8b1eb58e97a7cf184fe4d0190

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	base/trace_event/memory_dump_scheduler_unittest.cc	View		2 chunks	+1 line, -1 line	0 comments	Download

Total messages: 6 (3 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2952493002/1

3 years, 6 months ago (2017-06-20 01:02:56 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/2b1b0d7374dfeff8b1eb58e97a7cf184fe4d0190

3 years, 6 months ago (2017-06-20 03:48:51 UTC) #5

Message was sent while issue was closed.

LGTM thanks makes perfect sense.