Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Unified Diff: third_party/WebKit/Source/core/timing/PerformanceBase.cpp

Issue 2952413002: Remove out of spec FrameTiming members from Performance.idl (Closed)
Patch Set: Feedback Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/timing/PerformanceBase.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/timing/PerformanceBase.cpp
diff --git a/third_party/WebKit/Source/core/timing/PerformanceBase.cpp b/third_party/WebKit/Source/core/timing/PerformanceBase.cpp
index 904e27f9a98dc3e16ee837a97b18e4e2dacbc0a8..de5605392ab7b1d198f5b19741893cd01d207c2d 100644
--- a/third_party/WebKit/Source/core/timing/PerformanceBase.cpp
+++ b/third_party/WebKit/Source/core/timing/PerformanceBase.cpp
@@ -240,16 +240,6 @@ void PerformanceBase::setResourceTimingBufferSize(unsigned size) {
DispatchEvent(Event::Create(EventTypeNames::resourcetimingbufferfull));
}
-void PerformanceBase::clearFrameTimings() {
- frame_timing_buffer_.clear();
-}
-
-void PerformanceBase::setFrameTimingBufferSize(unsigned size) {
- frame_timing_buffer_size_ = size;
- if (IsFrameTimingBufferFull())
- DispatchEvent(Event::Create(EventTypeNames::frametimingbufferfull));
-}
-
bool PerformanceBase::PassesTimingAllowCheck(
const ResourceResponse& response,
const SecurityOrigin& initiator_security_origin,
@@ -438,13 +428,6 @@ bool PerformanceBase::IsResourceTimingBufferFull() {
void PerformanceBase::AddFrameTimingBuffer(PerformanceEntry& entry) {
panicker 2017/07/06 06:09:28 this should be deleted too
npm 2017/07/06 21:48:05 Done.
frame_timing_buffer_.push_back(&entry);
-
- if (IsFrameTimingBufferFull())
- DispatchEvent(Event::Create(EventTypeNames::frametimingbufferfull));
-}
-
-bool PerformanceBase::IsFrameTimingBufferFull() {
- return frame_timing_buffer_.size() >= frame_timing_buffer_size_;
}
void PerformanceBase::AddLongTaskTiming(double start_time,
« no previous file with comments | « third_party/WebKit/Source/core/timing/PerformanceBase.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698