Remove out of spec FrameTiming members from Performance.idl

Remove out of spec FrameTiming members from Performance.idl

BUG=735543
Review-Url: https://codereview.chromium.org/2952413002
Cr-Commit-Position: refs/heads/master@{#484827}
Committed: https://chromium.googlesource.com/chromium/src/+/908c23fcafc7ad610e0633ee2997deca7c462736

[npm, 2017-06-23 15:06:28]

The CQ bit was checked by npm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-23 15:06:33]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[npm, 2017-06-23 16:02:26]

Description was changed from

==========
Remove out of spec FrameTiming members from Performance.idl

BUG=735543
==========

to

==========
Remove out of spec FrameTiming members from Performance.idl

BUG=735543
==========

[npm, 2017-06-23 16:02:26]

npm@chromium.org changed reviewers:
+ jmedley@chromium.org, tdresser@chromium.org

[npm, 2017-06-23 16:02:37]

ptal

[panicker, 2017-06-23 16:55:40]

panicker@chromium.org changed reviewers:
+ panicker@chromium.org

[panicker, 2017-06-23 16:55:41]

Let's remove the event type: frametimingbufferfull
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/events/Ev...

https://codereview.chromium.org/2952413002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/timing/PerformanceBase.h (right):

https://codereview.chromium.org/2952413002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/timing/PerformanceBase.h:101: void
setFrameTimingBufferSize(unsigned);
this should be removed too

https://codereview.chromium.org/2952413002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/timing/PerformanceBase.h:103:
DEFINE_ATTRIBUTE_EVENT_LISTENER(frametimingbufferfull);
the event as well

[commit-bot: I haz the power, 2017-06-23 17:00:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-23 17:00:17]

Dry run: This issue passed the CQ dry run.

[npm, 2017-06-23 19:51:16]

The CQ bit was checked by npm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-23 19:51:39]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[npm, 2017-06-23 20:32:18]

I deleted the EventType but it is used in one of the methods I have not deleted.
ptal

https://codereview.chromium.org/2952413002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/timing/PerformanceBase.h (right):

https://codereview.chromium.org/2952413002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/timing/PerformanceBase.h:101: void
setFrameTimingBufferSize(unsigned);
On 2017/06/23 16:55:41, panicker wrote:
> this should be removed too

Done.

https://codereview.chromium.org/2952413002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/timing/PerformanceBase.h:103:
DEFINE_ATTRIBUTE_EVENT_LISTENER(frametimingbufferfull);
On 2017/06/23 16:55:41, panicker wrote:
> the event as well

Done.

[commit-bot: I haz the power, 2017-06-23 21:59:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-23 21:59:25]

Dry run: This issue passed the CQ dry run.

[npm, 2017-06-30 13:58:56]

Ping

[tdresser, 2017-06-30 14:03:50]

LGTM - but wait for panicker@'s review.

[panicker, 2017-07-06 06:09:28]

LGTM (modulo one comment)

https://codereview.chromium.org/2952413002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/timing/PerformanceBase.cpp (right):

https://codereview.chromium.org/2952413002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/timing/PerformanceBase.cpp:429: void
PerformanceBase::AddFrameTimingBuffer(PerformanceEntry& entry) {
this should be deleted too

[npm, 2017-07-06 21:48:05]

npm@chromium.org changed reviewers:
+ skobes@chromium.org

[npm, 2017-07-06 21:48:05]

+skobes for OWNER lgtm

https://codereview.chromium.org/2952413002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/timing/PerformanceBase.cpp (right):

https://codereview.chromium.org/2952413002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/timing/PerformanceBase.cpp:429: void
PerformanceBase::AddFrameTimingBuffer(PerformanceEntry& entry) {
On 2017/07/06 06:09:28, panicker wrote:
> this should be deleted too

Done.

[npm, 2017-07-06 21:48:49]

The CQ bit was checked by npm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-06 21:49:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[skobes, 2017-07-06 21:50:41]

RS LGTM for core/

[commit-bot: I haz the power, 2017-07-06 21:56:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-06 21:56:44]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[npm, 2017-07-06 23:10:24]

The CQ bit was checked by npm@chromium.org

[npm, 2017-07-06 23:10:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdresser@chromium.org, panicker@chromium.org
Link to the patchset: https://codereview.chromium.org/2952413002/#ps60001
(title: "More")

[commit-bot: I haz the power, 2017-07-06 23:10:42]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-07 02:50:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-07 02:50:53]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[npm, 2017-07-07 03:10:40]

The CQ bit was checked by npm@chromium.org

[commit-bot: I haz the power, 2017-07-07 03:10:53]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-07 04:01:47]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1499397040032780,
"parent_rev": "d6e1cab1edf5f432d2ce09ff8ee34fe14abaff5a", "commit_rev":
"908c23fcafc7ad610e0633ee2997deca7c462736"}

[commit-bot: I haz the power, 2017-07-07 04:02:10]

Description was changed from

==========
Remove out of spec FrameTiming members from Performance.idl

BUG=735543
==========

to

==========
Remove out of spec FrameTiming members from Performance.idl

BUG=735543

Review-Url: https://codereview.chromium.org/2952413002
Cr-Commit-Position: refs/heads/master@{#484827}
Committed:
https://chromium.googlesource.com/chromium/src/+/908c23fcafc7ad610e0633ee2997...
==========

[commit-bot: I haz the power, 2017-07-07 04:02:12]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/908c23fcafc7ad610e0633ee2997...