Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(971)

Issue 2952403003: Revert of ChromeWebView integration test for Incognito. (Closed)

Created:
3 years, 6 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 6 months ago
CC:
chromium-reviews, Eugene But (OOO till 7-30), ios-reviews+web_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of ChromeWebView integration test for Incognito. (patchset #3 id:40001 of https://codereview.chromium.org/2945563002/ ) Reason for revert: Failing on downstream bots Original issue's description: > ChromeWebView integration tests for Incognito. > > These tests verify that browsing data (cookie, localStorage) does not > leak between incognito and non-incognito web views. > > BUG=None > > Review-Url: https://codereview.chromium.org/2945563002 > Cr-Commit-Position: refs/heads/master@{#481755} > Committed: https://chromium.googlesource.com/chromium/src/+/aa87813942a324671466d574bc8567c0f74a7749 TBR=ichikawa@chromium.org,michaeldo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Review-Url: https://codereview.chromium.org/2952403003 Cr-Commit-Position: refs/heads/master@{#481892} Committed: https://chromium.googlesource.com/chromium/src/+/90e8368a5888862fbf336b1c4020edc36dbe53bc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -134 lines) Patch
M ios/web_view/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D ios/web_view/test/web_view_incognito_inttest.mm View 1 chunk +0 lines, -122 lines 0 comments Download
M ios/web_view/test/web_view_test_util.h View 1 chunk +0 lines, -5 lines 0 comments Download
M ios/web_view/test/web_view_test_util.mm View 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Eugene But (OOO till 7-30)
Created Revert of ChromeWebView integration test for Incognito.
3 years, 6 months ago (2017-06-23 15:19:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2952403003/1
3 years, 6 months ago (2017-06-23 15:19:36 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-06-23 15:20:12 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/90e8368a5888862fbf336b1c4020...

Powered by Google App Engine
This is Rietveld 408576698