Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Issue 2952383002: use ozone implementation for key code conversion when there is no X display (Closed)

Created:
3 years, 6 months ago by jzfeng
Modified:
3 years, 6 months ago
Reviewers:
johnchen, Sami
CC:
chromium-reviews, johnchen+watch_chromium.org, irisu
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

use ozone implementation for key code conversion when there is no X display BUG=chromedriver:1772 Review-Url: https://codereview.chromium.org/2952383002 Cr-Commit-Position: refs/heads/master@{#482084} Committed: https://chromium.googlesource.com/chromium/src/+/9b0c6e7bfb63034c8cd9784f5f18a83a92a95ca1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -16 lines) Patch
M chrome/test/chromedriver/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/keycode_text_conversion.h View 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/test/chromedriver/keycode_text_conversion_ozone.cc View 2 chunks +18 lines, -8 lines 0 comments Download
M chrome/test/chromedriver/keycode_text_conversion_x.cc View 3 chunks +11 lines, -7 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
jzfeng
This patch try to avoid the error message when there is no X display. It ...
3 years, 6 months ago (2017-06-23 08:53:00 UTC) #2
jzfeng
3 years, 6 months ago (2017-06-23 08:53:53 UTC) #4
jzfeng
3 years, 6 months ago (2017-06-23 08:56:07 UTC) #5
johnchen
lgtm
3 years, 6 months ago (2017-06-23 16:28:46 UTC) #10
Sami
lgtm, thanks for fixing this!
3 years, 6 months ago (2017-06-23 18:56:10 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2952383002/1
3 years, 6 months ago (2017-06-24 00:10:07 UTC) #13
commit-bot: I haz the power
3 years, 6 months ago (2017-06-24 00:14:48 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9b0c6e7bfb63034c8cd9784f5f18...

Powered by Google App Engine
This is Rietveld 408576698