Take into account expiration time when comparing tokens.

Take into account expiration time when comparing tokens.

When refreshing a token some (misbehaving) token providers may return existing
token, but with different expiration time. It confused the token cache that
assumed expiration time is a static property of the token.

R=iannucci@chromium.org
BUG=skia:6611
Review-Url: https://codereview.chromium.org/2952323002
Committed: https://github.com/luci/luci-go/commit/d68e694983c84b6dfed7c9eecc3196fadbf1b946

[iannucci, 2017-06-22 23:30:36]

gross... lgtm

[Vadim Sh., 2017-06-22 23:34:34]

The CQ bit was checked by vadimsh@chromium.org

[Vadim Sh., 2017-06-22 23:34:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
iannucci@chromium.org
Link to the patchset: https://codereview.chromium.org/2952323002/#ps20001
(title: "Take into account expiration time when comparing tokens.")

[commit-bot: I haz the power, 2017-06-22 23:34:44]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-22 23:47:54]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498174474078300,
"parent_rev": "b080ae464250e8d831a5d8ce09d00d781ae1528b", "commit_rev":
"d68e694983c84b6dfed7c9eecc3196fadbf1b946"}

[commit-bot: I haz the power, 2017-06-22 23:48:00]

Description was changed from

==========
Take into account expiration time when comparing tokens.

When refreshing a token some (misbehaving) token providers may return existing
token, but with different expiration time. It confused the token cache that
assumed expiration time is a static property of the token.

R=iannucci@chromium.org
BUG=skia:6611
==========

to

==========
Take into account expiration time when comparing tokens.

When refreshing a token some (misbehaving) token providers may return existing
token, but with different expiration time. It confused the token cache that
assumed expiration time is a static property of the token.

R=iannucci@chromium.org
BUG=skia:6611

Review-Url: https://codereview.chromium.org/2952323002
Committed:
https://github.com/luci/luci-go/commit/d68e694983c84b6dfed7c9eecc3196fadbf1b946
==========

[commit-bot: I haz the power, 2017-06-22 23:48:01]

Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/d68e694983c84b6dfed7c9eecc3196fadbf1b946