add more information to voice interaction root node.

add more information to voice interaction root node.

When the focused window is chrome browser and
not blocked profile, the URL will be sent along
with the voice interaction tree.

Also the browser's window position is sent. This
hopefully could benefit metalayer detection.

BUG=b:62872370
TEST=manual test with debug tool

Review-Url: https://codereview.chromium.org/2952293002
Cr-Commit-Position: refs/heads/master@{#481746}
Committed: https://chromium.googlesource.com/chromium/src/+/460df2746e65fd606c137999c0493f3d9b26e2b9

[Muyuan, 2017-06-22 21:24:42]

muyuanli@chromium.org changed reviewers:
+ xiyuan@chromium.org

[xiyuan, 2017-06-22 21:28:26]

lgtm with nits

https://codereview.chromium.org/2952293002/diff/1/chrome/browser/chromeos/arc...
File
chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_arc_home_service.cc
(right):

https://codereview.chromium.org/2952293002/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_arc_home_service.cc:68:
gfx::Rect bounds,
nit: gfx::Rect -> const gfx::Rect&

https://codereview.chromium.org/2952293002/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_arc_home_service.cc:78:
root->children.push_back(std::move(structure));
nit: seems like we can get rid of |structure| and inline
CreateVoiceInteractionStructure here.

[Muyuan, 2017-06-22 22:02:28]

https://codereview.chromium.org/2952293002/diff/1/chrome/browser/chromeos/arc...
File
chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_arc_home_service.cc
(right):

https://codereview.chromium.org/2952293002/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_arc_home_service.cc:68:
gfx::Rect bounds,
On 2017/06/22 21:28:26, xiyuan wrote:
> nit: gfx::Rect -> const gfx::Rect&

Done.

https://codereview.chromium.org/2952293002/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_arc_home_service.cc:78:
root->children.push_back(std::move(structure));
On 2017/06/22 21:28:26, xiyuan wrote:
> nit: seems like we can get rid of |structure| and inline
> CreateVoiceInteractionStructure here. 

Done.

[Muyuan, 2017-06-22 22:02:32]

The CQ bit was checked by muyuanli@chromium.org

[Muyuan, 2017-06-22 22:02:32]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/2952293002/#ps20001
(title: "address review comments")

[commit-bot: I haz the power, 2017-06-22 22:03:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-22 22:37:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-22 22:37:45]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, build has
not started yet; builder either lacks capacity or does not exist (misspelled?))

[Muyuan, 2017-06-23 00:31:59]

The CQ bit was checked by muyuanli@chromium.org

[commit-bot: I haz the power, 2017-06-23 00:32:26]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-23 00:42:24]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498177919348250,
"parent_rev": "4eb7d7b4449fee720181f73e4ea0947fc903b88d", "commit_rev":
"460df2746e65fd606c137999c0493f3d9b26e2b9"}

[commit-bot: I haz the power, 2017-06-23 00:42:40]

Description was changed from

==========
add more information to voice interaction root node.

When the focused window is chrome browser and
not blocked profile, the URL will be sent along
with the voice interaction tree.

Also the browser's window position is sent. This
hopefully could benefit metalayer detection.

BUG=b:62872370
TEST=manual test with debug tool
==========

to

==========
add more information to voice interaction root node.

When the focused window is chrome browser and
not blocked profile, the URL will be sent along
with the voice interaction tree.

Also the browser's window position is sent. This
hopefully could benefit metalayer detection.

BUG=b:62872370
TEST=manual test with debug tool

Review-Url: https://codereview.chromium.org/2952293002
Cr-Commit-Position: refs/heads/master@{#481746}
Committed:
https://chromium.googlesource.com/chromium/src/+/460df2746e65fd606c137999c049...
==========

[commit-bot: I haz the power, 2017-06-23 00:42:41]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/460df2746e65fd606c137999c049...