java_deobfuscate.py: Update regexp to match thread dump stacks

java_deobfuscate.py: Update regexp to match thread dump stacks

And simplify by having it use os.execv().

The lines in question look like:
06-22 13:58:02.895  4674  4674 E THREAD_STATE:     bLA.a(PG:173)

BUG=713710
Review-Url: https://codereview.chromium.org/2952283002
Cr-Commit-Position: refs/heads/master@{#481801}
Committed: https://chromium.googlesource.com/chromium/src/+/3a2065e70c18fc516374f011048cca308cf8ffa9

[agrieve, 2017-06-22 20:17:07]

Description was changed from

==========
java_deobfuscate.py: Update regexp to match thread dump stacks

And simplify by having it use os.execv().

The lines in question look like:
06-22 13:58:02.895  4674  4674 E THREAD_STATE:     bLA.a(PG:173)

BUG=713710
==========

to

==========
java_deobfuscate.py: Update regexp to match thread dump stacks

And simplify by having it use os.execv().

The lines in question look like:
06-22 13:58:02.895  4674  4674 E THREAD_STATE:     bLA.a(PG:173)

BUG=713710
==========

[agrieve, 2017-06-22 20:17:07]

agrieve@chromium.org changed reviewers:
+ mikecase@chromium.org

[agrieve, 2017-06-22 20:17:15]

On 2017/06/22 20:17:07, agrieve wrote:
> mailto:agrieve@chromium.org changed reviewers:
> + mailto:mikecase@chromium.org

🛌

[mikecase (-- gone --), 2017-06-22 20:34:16]

lgtm, but it'd be nice if you could add an example of the other type of line the
regex matches to the documentation

https://codereview.chromium.org/2952283002/diff/1/build/android/stacktrace/ja...
File build/android/stacktrace/java_deobfuscate.py (right):

https://codereview.chromium.org/2952283002/diff/1/build/android/stacktrace/ja...
build/android/stacktrace/java_deobfuscate.py:21: # But with the "at" part
changed to "(?::|\bat)", to account for lines like:
Do you have an example of the type of lines this normally matches?

[agrieve, 2017-06-23 01:48:22]

https://codereview.chromium.org/2952283002/diff/1/build/android/stacktrace/ja...
File build/android/stacktrace/java_deobfuscate.py (right):

https://codereview.chromium.org/2952283002/diff/1/build/android/stacktrace/ja...
build/android/stacktrace/java_deobfuscate.py:21: # But with the "at" part
changed to "(?::|\bat)", to account for lines like:
On 2017/06/22 20:34:16, mikecase wrote:
> Do you have an example of the type of lines this normally matches?

Done.

[agrieve, 2017-06-23 01:48:28]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2017-06-23 01:48:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
mikecase@chromium.org
Link to the patchset: https://codereview.chromium.org/2952283002/#ps20001
(title: "Add example of normal stack trace")

[commit-bot: I haz the power, 2017-06-23 01:48:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-23 03:14:39]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498182508474420,
"parent_rev": "5c438726c3ecb09e690cf079776315f7425cb3a0", "commit_rev":
"3a2065e70c18fc516374f011048cca308cf8ffa9"}

[commit-bot: I haz the power, 2017-06-23 03:14:52]

Description was changed from

==========
java_deobfuscate.py: Update regexp to match thread dump stacks

And simplify by having it use os.execv().

The lines in question look like:
06-22 13:58:02.895  4674  4674 E THREAD_STATE:     bLA.a(PG:173)

BUG=713710
==========

to

==========
java_deobfuscate.py: Update regexp to match thread dump stacks

And simplify by having it use os.execv().

The lines in question look like:
06-22 13:58:02.895  4674  4674 E THREAD_STATE:     bLA.a(PG:173)

BUG=713710

Review-Url: https://codereview.chromium.org/2952283002
Cr-Commit-Position: refs/heads/master@{#481801}
Committed:
https://chromium.googlesource.com/chromium/src/+/3a2065e70c18fc516374f011048c...
==========

[commit-bot: I haz the power, 2017-06-23 03:14:54]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3a2065e70c18fc516374f011048c...