Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 2952273002: Revert "Remove workaround for strikethrough text in iOS omnibox" (Closed)

Created:
3 years, 6 months ago by elawrence
Modified:
3 years, 6 months ago
CC:
chromium-reviews, marq+watch_chromium.org, jdonnelly+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Remove workaround for strikethrough text in iOS omnibox" This reverts commit 927047b0999e1fa6c164d581bdd5ec3b0e4d1f64. The workaround still appears to be necessary on iPhones running iOS 10.3.2. We'll keep the workaround until we hear back from Apple on our Radar bug report. BUG=711367 Review-Url: https://codereview.chromium.org/2952273002 Cr-Commit-Position: refs/heads/master@{#481651} Committed: https://chromium.googlesource.com/chromium/src/+/b83a4fa3ea202ca497cc9d82fcbb815b3e2ec512

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M ios/chrome/browser/ui/omnibox/omnibox_view_ios.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/omnibox/omnibox_view_ios.mm View 3 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
elawrence
PTAL? Sorry for the hassle; it appears that we need to keep this workaround in ...
3 years, 6 months ago (2017-06-22 20:06:12 UTC) #2
rohitrao (ping after 24h)
lgtm
3 years, 6 months ago (2017-06-22 20:08:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2952273002/1
3 years, 6 months ago (2017-06-22 20:16:41 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-22 20:31:32 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b83a4fa3ea202ca497cc9d82fcbb...

Powered by Google App Engine
This is Rietveld 408576698