Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 295223002: Fix incorrect usage of base::EmptyString16(). (Closed)

Created:
6 years, 7 months ago by Lei Zhang
Modified:
6 years, 7 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Fix incorrect usage of base::EmptyString16(). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272654

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M extensions/browser/extension_error_test_util.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Lei Zhang
6 years, 7 months ago (2014-05-23 08:38:22 UTC) #1
Devlin
lgtm. Thanks for pointing this out. :)
6 years, 7 months ago (2014-05-23 15:55:05 UTC) #2
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 7 months ago (2014-05-23 21:14:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/295223002/1
6 years, 7 months ago (2014-05-23 21:16:07 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-24 00:17:44 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-24 00:28:59 UTC) #6
Message was sent while issue was closed.
Change committed as 272654

Powered by Google App Engine
This is Rietveld 408576698