Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Side by Side Diff: extensions/browser/extension_error_test_util.cc

Issue 295223002: Fix incorrect usage of base::EmptyString16(). (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/browser/extension_error_test_util.h" 5 #include "extensions/browser/extension_error_test_util.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/strings/string_util.h" 8 #include "base/strings/string_util.h"
9 #include "base/strings/utf_string_conversions.h" 9 #include "base/strings/utf_string_conversions.h"
10 #include "content/public/common/url_constants.h" 10 #include "content/public/common/url_constants.h"
11 #include "extensions/browser/extension_error.h" 11 #include "extensions/browser/extension_error.h"
12 #include "extensions/common/constants.h" 12 #include "extensions/common/constants.h"
13 #include "extensions/common/stack_frame.h" 13 #include "extensions/common/stack_frame.h"
14 #include "url/gurl.h" 14 #include "url/gurl.h"
15 15
16 namespace extensions { 16 namespace extensions {
17 namespace error_test_util { 17 namespace error_test_util {
18 18
19 namespace { 19 namespace {
20 const char kDefaultStackTrace[] = "function_name (https://url.com:1:1)"; 20 const char kDefaultStackTrace[] = "function_name (https://url.com:1:1)";
21 } 21 }
22 22
23 scoped_ptr<ExtensionError> CreateNewRuntimeError( 23 scoped_ptr<ExtensionError> CreateNewRuntimeError(
24 const std::string& extension_id, 24 const std::string& extension_id,
25 const std::string& message, 25 const std::string& message,
26 bool from_incognito) { 26 bool from_incognito) {
27 StackTrace stack_trace; 27 StackTrace stack_trace;
28 scoped_ptr<StackFrame> frame = 28 scoped_ptr<StackFrame> frame =
29 StackFrame::CreateFromText(base::UTF8ToUTF16(kDefaultStackTrace)); 29 StackFrame::CreateFromText(base::ASCIIToUTF16(kDefaultStackTrace));
30 CHECK(frame.get()); 30 CHECK(frame.get());
31 stack_trace.push_back(*frame); 31 stack_trace.push_back(*frame);
32 32
33 base::string16 source = 33 base::string16 source =
34 base::UTF8ToUTF16(std::string(kExtensionScheme) + 34 base::UTF8ToUTF16(std::string(kExtensionScheme) +
35 content::kStandardSchemeSeparator + 35 content::kStandardSchemeSeparator +
36 extension_id); 36 extension_id);
37 37
38 return scoped_ptr<ExtensionError>( 38 return scoped_ptr<ExtensionError>(
39 new RuntimeError(extension_id, 39 new RuntimeError(extension_id,
(...skipping 10 matching lines...) Expand all
50 scoped_ptr<ExtensionError> CreateNewRuntimeError( 50 scoped_ptr<ExtensionError> CreateNewRuntimeError(
51 const std::string& extension_id, const std::string& message) { 51 const std::string& extension_id, const std::string& message) {
52 return CreateNewRuntimeError(extension_id, message, false); 52 return CreateNewRuntimeError(extension_id, message, false);
53 } 53 }
54 54
55 scoped_ptr<ExtensionError> CreateNewManifestError( 55 scoped_ptr<ExtensionError> CreateNewManifestError(
56 const std::string& extension_id, const std::string& message) { 56 const std::string& extension_id, const std::string& message) {
57 return scoped_ptr<ExtensionError>( 57 return scoped_ptr<ExtensionError>(
58 new ManifestError(extension_id, 58 new ManifestError(extension_id,
59 base::UTF8ToUTF16(message), 59 base::UTF8ToUTF16(message),
60 base::EmptyString16(), 60 base::string16(),
61 base::EmptyString16())); 61 base::string16()));
62 } 62 }
63 63
64 } // namespace error_test_util 64 } // namespace error_test_util
65 } // namespace extensions 65 } // namespace extensions
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698