Refactor SelectionController::SelectClosestMisspellingFromHitTestResult()

Refactor SelectionController::SelectClosestMisspellingFromHitTestResult()

This patch changes |SelectClosestMisspellingFromHitTestResult()| in
|SelectionController| class to utilize early-return style for improving
readability.

# Details
|SelectClosestMisspellingFromHitTestResult() calls 
|UpdateSelectionForMouseDownDispatchingSelectStart()| with non-null
|VisibleSelectionInFlatTree| if |pos.IsNotNull()| and
|marker != nullptr| are true, other wise this function calls null
|VisibleSelectionInFlatTree|.

Because |VisibleSelectionInFlatTree::AppendTrailingWhitespace()| appends a
whitespace only if selection is range, we don't need to call it for null
selection.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2952173002
Cr-Commit-Position: refs/heads/master@{#481751}
Committed: https://chromium.googlesource.com/chromium/src/+/5a5d5754d9d90c8869f2450c89e0ed0285242ab1

[yosin_UTC9, 2017-06-22 08:46:22]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-22 08:46:30]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-06-22 09:25:58]

Description was changed from

==========
2017-06-22T17:44:33

BUG=

2017-06-22T17:44:10
==========

to

==========
Refactor SelectionController::SelectClosestMisspellingFromHitTestResult()

This patch changes |SelectClosestMisspellingFromHitTestResult()| in
|SelectionController| class to utilize early-return style for improving
readability.

This function calls |UpdateSelectionForMouseDownDispatchingSelectStart()|
with non-null |VisibleSelectionInFlatTree| if |pos.IsNotNull()| and
|marker != nullptr| are true, other wise this function calls null
|VisibleSelectionInFlatTree|.

Because |VisibleSelectionInFlatTree::AppendTrailingWhitespace()| appends a
whitespace only if selection is range, we don't need to call it for null
selection.

BUG=n/a
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-06-22 09:26:28]

Description was changed from

==========
Refactor SelectionController::SelectClosestMisspellingFromHitTestResult()

This patch changes |SelectClosestMisspellingFromHitTestResult()| in
|SelectionController| class to utilize early-return style for improving
readability.

This function calls |UpdateSelectionForMouseDownDispatchingSelectStart()|
with non-null |VisibleSelectionInFlatTree| if |pos.IsNotNull()| and
|marker != nullptr| are true, other wise this function calls null
|VisibleSelectionInFlatTree|.

Because |VisibleSelectionInFlatTree::AppendTrailingWhitespace()| appends a
whitespace only if selection is range, we don't need to call it for null
selection.

BUG=n/a
TEST=n/a; no behavior changes
==========

to

==========
Refactor SelectionController::SelectClosestMisspellingFromHitTestResult()

This patch changes |SelectClosestMisspellingFromHitTestResult()| in
|SelectionController| class to utilize early-return style for improving
readability.

# Background
This function calls |UpdateSelectionForMouseDownDispatchingSelectStart()|
with non-null |VisibleSelectionInFlatTree| if |pos.IsNotNull()| and
|marker != nullptr| are true, other wise this function calls null
|VisibleSelectionInFlatTree|.

Because |VisibleSelectionInFlatTree::AppendTrailingWhitespace()| appends a
whitespace only if selection is range, we don't need to call it for null
selection.

BUG=n/a
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-06-22 09:47:20]

Description was changed from

==========
Refactor SelectionController::SelectClosestMisspellingFromHitTestResult()

This patch changes |SelectClosestMisspellingFromHitTestResult()| in
|SelectionController| class to utilize early-return style for improving
readability.

# Background
This function calls |UpdateSelectionForMouseDownDispatchingSelectStart()|
with non-null |VisibleSelectionInFlatTree| if |pos.IsNotNull()| and
|marker != nullptr| are true, other wise this function calls null
|VisibleSelectionInFlatTree|.

Because |VisibleSelectionInFlatTree::AppendTrailingWhitespace()| appends a
whitespace only if selection is range, we don't need to call it for null
selection.

BUG=n/a
TEST=n/a; no behavior changes
==========

to

==========
Refactor SelectionController::SelectClosestMisspellingFromHitTestResult()

This patch changes |SelectClosestMisspellingFromHitTestResult()| in
|SelectionController| class to utilize early-return style for improving
readability.

# Details
|SelectClosestMisspellingFromHitTestResult() calls 
|UpdateSelectionForMouseDownDispatchingSelectStart()| with non-null
|VisibleSelectionInFlatTree| if |pos.IsNotNull()| and
|marker != nullptr| are true, other wise this function calls null
|VisibleSelectionInFlatTree|.

Because |VisibleSelectionInFlatTree::AppendTrailingWhitespace()| appends a
whitespace only if selection is range, we don't need to call it for null
selection.

BUG=n/a
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-06-22 09:47:31]

Description was changed from

==========
Refactor SelectionController::SelectClosestMisspellingFromHitTestResult()

This patch changes |SelectClosestMisspellingFromHitTestResult()| in
|SelectionController| class to utilize early-return style for improving
readability.

# Details
|SelectClosestMisspellingFromHitTestResult() calls 
|UpdateSelectionForMouseDownDispatchingSelectStart()| with non-null
|VisibleSelectionInFlatTree| if |pos.IsNotNull()| and
|marker != nullptr| are true, other wise this function calls null
|VisibleSelectionInFlatTree|.

Because |VisibleSelectionInFlatTree::AppendTrailingWhitespace()| appends a
whitespace only if selection is range, we don't need to call it for null
selection.

BUG=n/a
TEST=n/a; no behavior changes
==========

to

==========
Refactor SelectionController::SelectClosestMisspellingFromHitTestResult()

This patch changes |SelectClosestMisspellingFromHitTestResult()| in
|SelectionController| class to utilize early-return style for improving
readability.

# Details
|SelectClosestMisspellingFromHitTestResult() calls 
|UpdateSelectionForMouseDownDispatchingSelectStart()| with non-null
|VisibleSelectionInFlatTree| if |pos.IsNotNull()| and
|marker != nullptr| are true, other wise this function calls null
|VisibleSelectionInFlatTree|.

Because |VisibleSelectionInFlatTree::AppendTrailingWhitespace()| appends a
whitespace only if selection is range, we don't need to call it for null
selection.

BUG=n/a
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-06-22 09:47:53]

yosin@chromium.org changed reviewers:
+ xiaochengh@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2017-06-22 09:47:54]

PTAL

[commit-bot: I haz the power, 2017-06-22 10:29:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-22 10:29:49]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2017-06-22 18:41:43]

lgtm

[yosin_UTC9, 2017-06-23 00:50:18]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-06-23 00:50:47]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-23 00:55:21]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1498179018537870, "parent_rev":
"3e24f475f9f865b61b3bf4b61f86276cc983d243", "commit_rev":
"5a5d5754d9d90c8869f2450c89e0ed0285242ab1"}

[commit-bot: I haz the power, 2017-06-23 00:55:34]

Description was changed from

==========
Refactor SelectionController::SelectClosestMisspellingFromHitTestResult()

This patch changes |SelectClosestMisspellingFromHitTestResult()| in
|SelectionController| class to utilize early-return style for improving
readability.

# Details
|SelectClosestMisspellingFromHitTestResult() calls 
|UpdateSelectionForMouseDownDispatchingSelectStart()| with non-null
|VisibleSelectionInFlatTree| if |pos.IsNotNull()| and
|marker != nullptr| are true, other wise this function calls null
|VisibleSelectionInFlatTree|.

Because |VisibleSelectionInFlatTree::AppendTrailingWhitespace()| appends a
whitespace only if selection is range, we don't need to call it for null
selection.

BUG=n/a
TEST=n/a; no behavior changes
==========

to

==========
Refactor SelectionController::SelectClosestMisspellingFromHitTestResult()

This patch changes |SelectClosestMisspellingFromHitTestResult()| in
|SelectionController| class to utilize early-return style for improving
readability.

# Details
|SelectClosestMisspellingFromHitTestResult() calls 
|UpdateSelectionForMouseDownDispatchingSelectStart()| with non-null
|VisibleSelectionInFlatTree| if |pos.IsNotNull()| and
|marker != nullptr| are true, other wise this function calls null
|VisibleSelectionInFlatTree|.

Because |VisibleSelectionInFlatTree::AppendTrailingWhitespace()| appends a
whitespace only if selection is range, we don't need to call it for null
selection.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2952173002
Cr-Commit-Position: refs/heads/master@{#481751}
Committed:
https://chromium.googlesource.com/chromium/src/+/5a5d5754d9d90c8869f2450c89e0...
==========

[commit-bot: I haz the power, 2017-06-23 00:55:35]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5a5d5754d9d90c8869f2450c89e0...