Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2952133002: Use task runner in version_updater_win.cc. (Closed)

Created:
3 years, 6 months ago by calamity
Modified:
3 years, 5 months ago
Reviewers:
benry, gab, Peter Kasting
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use task runner in version_updater_win.cc. BUG=667892 Review-Url: https://codereview.chromium.org/2952133002 Cr-Commit-Position: refs/heads/master@{#488160} Committed: https://chromium.googlesource.com/chromium/src/+/c59edd83ceaeb3b0c4fb8dc62281eb57512dcd60

Patch Set 1 : #

Total comments: 6

Patch Set 2 : address easy comments #

Patch Set 3 : remove task runner injection #

Total comments: 4

Patch Set 4 : fix tests #

Patch Set 5 : rebase #

Total comments: 6

Patch Set 6 : address comments #

Total comments: 2

Patch Set 7 : fix nit #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -69 lines) Patch
M chrome/browser/google/google_update_win.h View 1 2 3 4 5 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/google/google_update_win.cc View 1 2 3 4 5 11 chunks +31 lines, -25 lines 0 comments Download
M chrome/browser/google/google_update_win_unittest.cc View 1 2 3 4 5 13 chunks +15 lines, -13 lines 1 comment Download
M chrome/browser/ui/webui/help/version_updater_win.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/help/version_updater_win.cc View 1 2 3 4 5 6 3 chunks +15 lines, -27 lines 0 comments Download

Messages

Total messages: 33 (21 generated)
calamity
PTAL, thanks!
3 years, 5 months ago (2017-07-06 05:51:32 UTC) #8
gab
https://codereview.chromium.org/2952133002/diff/40001/chrome/browser/ui/webui/help/version_updater_win.cc File chrome/browser/ui/webui/help/version_updater_win.cc (left): https://codereview.chromium.org/2952133002/diff/40001/chrome/browser/ui/webui/help/version_updater_win.cc#oldcode89 chrome/browser/ui/webui/help/version_updater_win.cc:89: DCHECK_CURRENTLY_ON(content::BrowserThread::UI); It's fine to keep these (the UI thread ...
3 years, 5 months ago (2017-07-11 23:40:15 UTC) #11
calamity
https://codereview.chromium.org/2952133002/diff/40001/chrome/browser/ui/webui/help/version_updater_win.cc File chrome/browser/ui/webui/help/version_updater_win.cc (left): https://codereview.chromium.org/2952133002/diff/40001/chrome/browser/ui/webui/help/version_updater_win.cc#oldcode89 chrome/browser/ui/webui/help/version_updater_win.cc:89: DCHECK_CURRENTLY_ON(content::BrowserThread::UI); On 2017/07/11 23:40:15, gab (in-out til july17) wrote: ...
3 years, 5 months ago (2017-07-12 07:11:40 UTC) #13
gab
Thanks for working on this, comments below. https://codereview.chromium.org/2952133002/diff/100001/chrome/browser/google/google_update_win.cc File chrome/browser/google/google_update_win.cc (right): https://codereview.chromium.org/2952133002/diff/100001/chrome/browser/google/google_update_win.cc#newcode397 chrome/browser/google/google_update_win.cc:397: : task_runner_(base::CreateSingleThreadTaskRunnerWithTraits( ...
3 years, 5 months ago (2017-07-17 17:14:40 UTC) #14
calamity
https://codereview.chromium.org/2952133002/diff/100001/chrome/browser/google/google_update_win.cc File chrome/browser/google/google_update_win.cc (right): https://codereview.chromium.org/2952133002/diff/100001/chrome/browser/google/google_update_win.cc#newcode397 chrome/browser/google/google_update_win.cc:397: : task_runner_(base::CreateSingleThreadTaskRunnerWithTraits( On 2017/07/17 17:14:40, gab wrote: > Does ...
3 years, 5 months ago (2017-07-19 09:03:39 UTC) #17
gab
lgtm w/ comments https://codereview.chromium.org/2952133002/diff/180001/chrome/browser/google/google_update_win.cc File chrome/browser/google/google_update_win.cc (left): https://codereview.chromium.org/2952133002/diff/180001/chrome/browser/google/google_update_win.cc#oldcode408 chrome/browser/google/google_update_win.cc:408: DCHECK(result_runner_->BelongsToCurrentThread()); Why remove these checks? With ...
3 years, 5 months ago (2017-07-19 15:15:24 UTC) #18
calamity
I think I did what you recommended. Let me know if I've done something wrong. ...
3 years, 5 months ago (2017-07-20 03:56:20 UTC) #20
Peter Kasting
LGTM https://codereview.chromium.org/2952133002/diff/200001/chrome/browser/ui/webui/help/version_updater_win.cc File chrome/browser/ui/webui/help/version_updater_win.cc (right): https://codereview.chromium.org/2952133002/diff/200001/chrome/browser/ui/webui/help/version_updater_win.cc#newcode39 chrome/browser/ui/webui/help/version_updater_win.cc:39: Status status = CHECKING; Nit: This variable can ...
3 years, 5 months ago (2017-07-20 05:28:53 UTC) #21
calamity
https://codereview.chromium.org/2952133002/diff/200001/chrome/browser/ui/webui/help/version_updater_win.cc File chrome/browser/ui/webui/help/version_updater_win.cc (right): https://codereview.chromium.org/2952133002/diff/200001/chrome/browser/ui/webui/help/version_updater_win.cc#newcode39 chrome/browser/ui/webui/help/version_updater_win.cc:39: Status status = CHECKING; On 2017/07/20 05:28:53, Peter Kasting ...
3 years, 5 months ago (2017-07-20 05:54:48 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2952133002/220001
3 years, 5 months ago (2017-07-20 07:17:03 UTC) #29
commit-bot: I haz the power
Committed patchset #7 (id:220001) as https://chromium.googlesource.com/chromium/src/+/c59edd83ceaeb3b0c4fb8dc62281eb57512dcd60
3 years, 5 months ago (2017-07-20 07:21:03 UTC) #32
gab
3 years, 5 months ago (2017-07-20 15:51:03 UTC) #33
Message was sent while issue was closed.
https://codereview.chromium.org/2952133002/diff/220001/chrome/browser/google/...
File chrome/browser/google/google_update_win_unittest.cc (right):

https://codereview.chromium.org/2952133002/diff/220001/chrome/browser/google/...
chrome/browser/google/google_update_win_unittest.cc:599:
SetUpdateDriverTaskRunnerForTesting(task_runner_.get());
Also set it to nullptr in TearDown() so future tests in the same process don't
flake by unintentionally grabbing a freed SequencedTaskRunner* from the global.

Powered by Google App Engine
This is Rietveld 408576698