Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenuHelper.java

Issue 2951963002: Allow choosing target language in more languages menu(translate infobar) (Closed)
Patch Set: fix Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenuHelper.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenuHelper.java b/chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenuHelper.java
index 0d0065deb64babeb5d576889d4afa19aa80b912a..112a49315ed7e496004a4019e2ba7349b77a0045 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenuHelper.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenuHelper.java
@@ -67,9 +67,11 @@ public class TranslateMenuHelper implements AdapterView.OnItemClickListener {
} else {
for (int i = 0; i < mOptions.allLanguages().size(); ++i) {
String code = mOptions.allLanguages().get(i).mLanguageCode;
- // Don't show target or source language in the menu list.
- if (code.equals(mOptions.targetLanguageCode())
- || code.equals(mOptions.sourceLanguageCode())) {
+ // Avoid source language in both the source and target language list.
+ // Avoid target language only in the target language list.
+ if (code.equals(mOptions.sourceLanguageCode())
+ || (menuType == TranslateMenu.MENU_TARGET_LANGUAGE
+ && code.equals(mOptions.targetLanguageCode()))) {
continue;
}
menuList.add(new TranslateMenu.MenuItem(TranslateMenu.ITEM_LANGUAGE, i, code));
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698