Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1760)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java

Issue 2951963002: Allow choosing target language in more languages menu(translate infobar) (Closed)
Patch Set: fix Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenuHelper.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java b/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java
index 1dc3f014e3602bc77470b23606ee8104b89b0845..21a032f70dc2218818e557a1ab4c193ece0e623b 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java
@@ -411,6 +411,12 @@ public class TranslateCompactInfoBar extends InfoBar
@Override
public void onSourceMenuItemClicked(String code) {
+ // If source language is same as target language, the infobar will dismiss and no
+ // translation will be done.
+ if (mOptions.targetLanguageCode().equals(code)) {
+ closeInfobar(true);
+ return;
+ }
// Reset source code in both UI and native.
if (mNativeTranslateInfoBarPtr != 0 && mOptions.setSourceLanguage(code)) {
recordInfobarLanguageData(
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenuHelper.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698