Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Issue 2951903002: [vm-service] Use consistent success response for _requestHeapSnapshot. (Closed)

Created:
3 years, 6 months ago by rmacnak
Modified:
3 years, 6 months ago
Reviewers:
cbernaschina
CC:
reviews_dartlang.org, turnidge, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[vm-service] Use consistent success response for _requestHeapSnapshot. Fixes #29956 R=cbernaschina@google.com Committed: https://github.com/dart-lang/sdk/commit/1daac1c651c63d6ee35bdda795107a186fecaa72

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M runtime/vm/service.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
3 years, 6 months ago (2017-06-21 01:19:56 UTC) #2
cbernaschina
On 2017/06/21 01:19:56, rmacnak wrote: lgtm
3 years, 6 months ago (2017-06-22 01:20:48 UTC) #3
rmacnak
3 years, 6 months ago (2017-06-22 16:47:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1daac1c651c63d6ee35bdda795107a186fecaa72 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698