Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Unified Diff: runtime/vm/service.cc

Issue 2951903002: [vm-service] Use consistent success response for _requestHeapSnapshot. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/service.cc
diff --git a/runtime/vm/service.cc b/runtime/vm/service.cc
index 0d134e86371811d3bcae2afc6087014e140ebe10..4c155413379791a8e66d6a217717fdcf49b823c0 100644
--- a/runtime/vm/service.cc
+++ b/runtime/vm/service.cc
@@ -3510,8 +3510,7 @@ static bool RequestHeapSnapshot(Thread* thread, JSONStream* js) {
Service::SendGraphEvent(thread, roots, collect_garbage);
}
// TODO(koda): Provide some id that ties this request to async response(s).
- JSONObject jsobj(js);
- jsobj.AddProperty("type", "OK");
+ PrintSuccess(js);
return true;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698