Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2951883003: android: Stricter android-app:// referrer handling. (Closed)

Created:
3 years, 6 months ago by Benoit L
Modified:
3 years, 6 months ago
Reviewers:
Maria
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

android: Stricter android-app:// referrer handling. No longer accept referrers without a scheme, for instance android-app:/// is invalid. BUG=589428 Review-Url: https://codereview.chromium.org/2951883003 Cr-Commit-Position: refs/heads/master@{#481480} Committed: https://chromium.googlesource.com/chromium/src/+/1d7b81330fbe983d0e301f599f6b822658355ec4

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -9 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/IntentHandler.java View 1 2 3 chunks +9 lines, -6 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/IntentHandlerTest.java View 1 2 3 1 chunk +13 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/TabsOpenedFromExternalAppTest.java View 1 chunk +20 lines, -1 line 0 comments Download

Messages

Total messages: 14 (10 generated)
Benoit L
3 years, 6 months ago (2017-06-21 16:29:34 UTC) #5
Maria
lgtm
3 years, 6 months ago (2017-06-21 21:11:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2951883003/60001
3 years, 6 months ago (2017-06-22 08:38:59 UTC) #11
commit-bot: I haz the power
3 years, 6 months ago (2017-06-22 08:42:02 UTC) #14
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/1d7b81330fbe983d0e301f599f6b...

Powered by Google App Engine
This is Rietveld 408576698