Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2951883002: Revert of Move SafeBrowsing files from //chrome/browser to a separate target. (Closed)

Created:
3 years, 6 months ago by pdr.
Modified:
3 years, 6 months ago
CC:
chromium-reviews, grt+watch_chromium.org, timvolodine, vakh+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move SafeBrowsing files from //chrome/browser to a separate target. (patchset #5 id:80001 of https://codereview.chromium.org/2940403002/ ) Reason for revert: This caused compile failures (https://uberchromegw.corp.google.com/i/chromium.win/builders/Win%20x64%20Builder/builds/34160) Original issue's description: > Move SafeBrowsing files from //chrome/browser to a separate target. > > BUG= > > Review-Url: https://codereview.chromium.org/2940403002 > Cr-Commit-Position: refs/heads/master@{#481019} > Committed: https://chromium.googlesource.com/chromium/src/+/e4da0e76b5b75d453fec094f62ad06659e66708e TBR=rockot@chromium.org,vakh@chromium.org,yzshen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2951883002 Cr-Commit-Position: refs/heads/master@{#481029} Committed: https://chromium.googlesource.com/chromium/src/+/b1ec588ea976b5e1ac93878c7d75794ac3dad2e4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+219 lines, -236 lines) Patch
M chrome/browser/BUILD.gn View 5 chunks +219 lines, -1 line 0 comments Download
M chrome/browser/extensions/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/BUILD.gn View 2 chunks +0 lines, -233 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
pdr.
Created Revert of Move SafeBrowsing files from //chrome/browser to a separate target.
3 years, 6 months ago (2017-06-20 23:42:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2951883002/1
3 years, 6 months ago (2017-06-20 23:43:26 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-06-20 23:44:05 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b1ec588ea976b5e1ac93878c7d75...

Powered by Google App Engine
This is Rietveld 408576698