Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1189)

Issue 2951833002: [DevTools] Support multiple sessions in dedicated workers (Closed)

Created:
3 years, 6 months ago by dgozman
Modified:
3 years, 6 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, kinuko+worker_chromium.org, jsbell+serviceworker_chromium.org, caseq+blink_chromium.org, shimazu+serviceworker_chromium.org, nhiroki, serviceworker-reviews, kinuko+serviceworker, lushnikov+blink_chromium.org, shimazu+worker_chromium.org, haraken, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, michaeln, devtools-reviews_chromium.org, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, tzik, blink-worker-reviews_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Support multiple sessions in dedicated workers This is internal refactoring only, protocol does not expose an ability to connect multiple sessions yet. BUG=590878 Review-Url: https://codereview.chromium.org/2951833002 Cr-Commit-Position: refs/heads/master@{#480973} Committed: https://chromium.googlesource.com/chromium/src/+/451245fd167ca58e0a604c7b0b94df4d5070e794

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -88 lines) Patch
M third_party/WebKit/Source/core/exported/WebSharedWorkerImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/exported/WebSharedWorkerImpl.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.cpp View 7 chunks +17 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerInspectorController.h View 3 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp View 2 chunks +31 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/core/workers/SharedWorkerReportingProxy.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/SharedWorkerReportingProxy.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/ThreadedObjectProxyBase.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/ThreadedObjectProxyBase.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerInspectorProxy.h View 3 chunks +9 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp View 3 chunks +40 lines, -29 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerReportingProxy.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/exported/WebEmbeddedWorkerImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/exported/WebEmbeddedWorkerImpl.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeProxy.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeProxy.cpp View 2 chunks +3 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (10 generated)
dgozman
Take a look please.
3 years, 6 months ago (2017-06-20 18:45:06 UTC) #3
pfeldman
lgtm
3 years, 6 months ago (2017-06-20 19:05:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2951833002/1
3 years, 6 months ago (2017-06-20 21:39:51 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-20 21:56:09 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/451245fd167ca58e0a604c7b0b94...

Powered by Google App Engine
This is Rietveld 408576698