Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2951803005: Set and keep parent function of signature functions. (Closed)

Created:
3 years, 6 months ago by regis
Modified:
3 years, 6 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Set and keep parent function of signature functions. Fix function type parameter comparison in type tests. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/1f5f3ed79f4c152a7ba7f3f68367196763da15de

Patch Set 1 #

Total comments: 4

Patch Set 2 : address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -26 lines) Patch
M runtime/vm/class_finalizer.cc View 1 chunk +5 lines, -1 line 0 comments Download
M runtime/vm/kernel_binary_flowgraph.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M runtime/vm/object.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 7 chunks +39 lines, -12 lines 0 comments Download
M runtime/vm/parser.cc View 1 3 chunks +9 lines, -10 lines 0 comments Download
M runtime/vm/runtime_entry.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
regis
3 years, 6 months ago (2017-06-21 18:42:44 UTC) #2
rmacnak
lgtm https://codereview.chromium.org/2951803005/diff/1/runtime/vm/kernel_binary_flowgraph.cc File runtime/vm/kernel_binary_flowgraph.cc (right): https://codereview.chromium.org/2951803005/diff/1/runtime/vm/kernel_binary_flowgraph.cc#newcode1484 runtime/vm/kernel_binary_flowgraph.cc:1484: Function::NewSignatureFunction(*active_class_->klass, Function::Handle(), Handle(Z) https://codereview.chromium.org/2951803005/diff/1/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://codereview.chromium.org/2951803005/diff/1/runtime/vm/parser.cc#newcode5442 ...
3 years, 6 months ago (2017-06-21 20:10:00 UTC) #3
regis
Thanks! https://codereview.chromium.org/2951803005/diff/1/runtime/vm/kernel_binary_flowgraph.cc File runtime/vm/kernel_binary_flowgraph.cc (right): https://codereview.chromium.org/2951803005/diff/1/runtime/vm/kernel_binary_flowgraph.cc#newcode1484 runtime/vm/kernel_binary_flowgraph.cc:1484: Function::NewSignatureFunction(*active_class_->klass, Function::Handle(), On 2017/06/21 20:10:00, rmacnak wrote: > ...
3 years, 6 months ago (2017-06-21 20:14:01 UTC) #4
regis
Committed patchset #2 (id:20001) manually as 1f5f3ed79f4c152a7ba7f3f68367196763da15de (presubmit successful).
3 years, 6 months ago (2017-06-21 20:16:31 UTC) #6
Kevin Millikin (Google)
3 years, 6 months ago (2017-06-23 09:35:30 UTC) #7
Message was sent while issue was closed. 
On 2017/06/21 20:16:31, regis wrote:
> Committed patchset #2 (id:20001) manually as
> 1f5f3ed79f4c152a7ba7f3f68367196763da15de (presubmit successful).

It looks like this triggers an assertion in the clustered snapshot writer.  See
https://github.com/dart-lang/sdk/issues/29994

I'll mark the test expectation as Crash for now, but please take a look.

Powered by Google App Engine
This is Rietveld 408576698