Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Side by Side Diff: runtime/vm/kernel_binary_flowgraph.cc

Issue 2951803005: Set and keep parent function of signature functions. (Closed)
Patch Set: address review comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/class_finalizer.cc ('k') | runtime/vm/object.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/kernel_binary_flowgraph.h" 5 #include "vm/kernel_binary_flowgraph.h"
6 6
7 #include "vm/compiler.h" 7 #include "vm/compiler.h"
8 #include "vm/longjump.h" 8 #include "vm/longjump.h"
9 #include "vm/object_store.h" 9 #include "vm/object_store.h"
10 10
(...skipping 1462 matching lines...) Expand 10 before | Expand all | Expand 10 after
1473 // The spec describes in section "19.1 Static Types": 1473 // The spec describes in section "19.1 Static Types":
1474 // 1474 //
1475 // Any use of a malformed type gives rise to a static warning. A 1475 // Any use of a malformed type gives rise to a static warning. A
1476 // malformed type is then interpreted as dynamic by the static type 1476 // malformed type is then interpreted as dynamic by the static type
1477 // checker and the runtime unless explicitly specified otherwise. 1477 // checker and the runtime unless explicitly specified otherwise.
1478 // 1478 //
1479 // So we convert malformed return/parameter types to `dynamic`. 1479 // So we convert malformed return/parameter types to `dynamic`.
1480 TypeParameterScope scope(this, first_item_offest, list_length); 1480 TypeParameterScope scope(this, first_item_offest, list_length);
1481 1481
1482 Function& signature_function = Function::ZoneHandle( 1482 Function& signature_function = Function::ZoneHandle(
1483 Z, Function::NewSignatureFunction(*active_class_->klass, 1483 Z,
1484 TokenPosition::kNoSource)); 1484 Function::NewSignatureFunction(*active_class_->klass, Function::Handle(Z),
1485 TokenPosition::kNoSource));
1485 1486
1486 intptr_t required_count; 1487 intptr_t required_count;
1487 intptr_t all_count; 1488 intptr_t all_count;
1488 intptr_t positional_count; 1489 intptr_t positional_count;
1489 if (!simple) { 1490 if (!simple) {
1490 required_count = builder_->ReadUInt(); // read required parameter count. 1491 required_count = builder_->ReadUInt(); // read required parameter count.
1491 all_count = builder_->ReadUInt(); // read total parameter count. 1492 all_count = builder_->ReadUInt(); // read total parameter count.
1492 positional_count = 1493 positional_count =
1493 builder_->ReadListLength(); // read positional_parameters list length. 1494 builder_->ReadListLength(); // read positional_parameters list length.
1494 } else { 1495 } else {
(...skipping 5434 matching lines...) Expand 10 before | Expand all | Expand 10 after
6929 metadata_values.SetAt(i, value); 6930 metadata_values.SetAt(i, value);
6930 } 6931 }
6931 6932
6932 return metadata_values.raw(); 6933 return metadata_values.raw();
6933 } 6934 }
6934 6935
6935 } // namespace kernel 6936 } // namespace kernel
6936 } // namespace dart 6937 } // namespace dart
6937 6938
6938 #endif // !defined(DART_PRECOMPILED_RUNTIME) 6939 #endif // !defined(DART_PRECOMPILED_RUNTIME)
OLDNEW
« no previous file with comments | « runtime/vm/class_finalizer.cc ('k') | runtime/vm/object.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698