Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(930)

Issue 2951803002: Reland of zone/drm: Only reuse ScanoutBuffers with compatible modifiers

Created:
3 years, 6 months ago by hoegsberg1
Modified:
3 years, 6 months ago
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org, piman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of zone/drm: Only reuse ScanoutBuffers with compatible modifiers (patchset #1 id:1 of https://codereview.chromium.org/2948513003/ ) Reason for revert: Let's revert the revert and land the fix: https://chromium-review.googlesource.com/c/540817/?polygerrit=1 Original issue's description: > Revert of ozone/drm: Only reuse ScanoutBuffers with compatible modifiers (patchset #4 id:60001 of https://codereview.chromium.org/2919533003/ ) > > Reason for revert: > This breaks nyan (see crbug.com/734074) so let's revert to hopefully have a green PFQ run today. > > Original issue's description: > > ozone/drm: Only reuse ScanoutBuffers with compatible modifiers > > > > Now that we have modifiers, we need to make sure that not just the > > format, but also the format modifer is compatible with the > > HardwareDisplayController where we want to use the buffer. > > > > BUG=b/38217940 > > TEST=Plug in external monitor that supports same resolution as internal > > panel with mirror mode enabled > > > > Review-Url: https://codereview.chromium.org/2919533003 > > Cr-Commit-Position: refs/heads/master@{#479813} > > Committed: https://chromium.googlesource.com/chromium/src/+/9947afe90294ff5ad902e2cc02f8064506f7f0a4 > > TBR=dcastagna@chromium.org,reveman@chromium.org,dnicoara@chromium.org,hoegsberg@google.com,hoegsberg@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=b/38217940 > > Review-Url: https://codereview.chromium.org/2948513003 > Cr-Commit-Position: refs/heads/master@{#480683} > Committed: https://chromium.googlesource.com/chromium/src/+/d4a230f60cc702283992d180a1cd77109d8459bd TBR=dcastagna@chromium.org,reveman@chromium.org,dnicoara@chromium.org,hoegsberg@chromium.org,marcheu@chromium.org,marcheu@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=b/38217940

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -25 lines) Patch
M ui/ozone/platform/drm/gpu/drm_buffer.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_buffer.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/ozone/platform/drm/gpu/gbm_buffer.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/gbm_buffer.cc View 3 chunks +2 lines, -7 lines 0 comments Download
M ui/ozone/platform/drm/gpu/gbm_buffer_base.h View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/ozone/platform/drm/gpu/gbm_buffer_base.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M ui/ozone/platform/drm/gpu/mock_hardware_display_plane_manager.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/mock_scanout_buffer.h View 3 chunks +7 lines, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/mock_scanout_buffer.cc View 2 chunks +22 lines, -4 lines 0 comments Download
M ui/ozone/platform/drm/gpu/mock_scanout_buffer_generator.h View 1 chunk +6 lines, -0 lines 0 comments Download
M ui/ozone/platform/drm/gpu/mock_scanout_buffer_generator.cc View 1 chunk +10 lines, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/scanout_buffer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/ozone/platform/drm/gpu/screen_manager.cc View 1 chunk +19 lines, -6 lines 0 comments Download
M ui/ozone/platform/drm/gpu/screen_manager_unittest.cc View 4 chunks +35 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
hoegsberg1
Created Reland of zone/drm: Only reuse ScanoutBuffers with compatible modifiers
3 years, 6 months ago (2017-06-20 17:59:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2951803002/1
3 years, 6 months ago (2017-06-20 18:00:20 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-06-20 18:00:22 UTC) #5
No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

Powered by Google App Engine
This is Rietveld 408576698